Skip to main content

Last Call Review of draft-ietf-lamps-rfc5990bis-05
review-ietf-lamps-rfc5990bis-05-secdir-lc-eastlake-2024-04-22-00

Request Review of draft-ietf-lamps-rfc5990bis
Requested revision No specific revision (document currently at 07)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2024-04-23
Requested 2024-04-09
Authors Russ Housley , Sean Turner
I-D last updated 2024-04-22
Completed reviews Genart Last Call review of -05 by Christer Holmberg (diff)
Secdir Last Call review of -05 by Donald E. Eastlake 3rd (diff)
Opsdir Last Call review of -05 by Dhruv Dhody (diff)
Assignment Reviewer Donald E. Eastlake 3rd
State Completed
Request Last Call review on draft-ietf-lamps-rfc5990bis by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/iIzhWvnGOug709QJHENgFM7-6eA
Reviewed revision 05 (document currently at 07)
Result Has nits
Completed 2024-04-22
review-ietf-lamps-rfc5990bis-05-secdir-lc-eastlake-2024-04-22-00
I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG. Document editors and WG chairs should treat these comments just
like any other last call comments.

The summary of the review is: Ready with nits.

This document specifies conventions for using RSA-KEM as a standalone
KEM and using it with the Cryptographic Message Syntax (CMS).

I believe the document is sound and complete but found two trivial
typos as below. The document did seem a bit dense and terse in some
parts.

Trivia:

Note duplicated phrase in the 2nd sentence of this paragraph:
   The RSA-KEM Algorithm provides a fixed-length ciphertext.  The
   recipient MUST check that the received byte string is the expected
   length and the expected length and corresponds to an integer in the
   expected range prior to attempting decryption with their RSA private
   key as described in Steps 1 and 2 of Appendix A.2.

Appendix A: Inconsistent capitalization: SS, ss


I did not check Appendices B through D.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com