Last Call Review of draft-ietf-lamps-rfc7030est-clarify-07
review-ietf-lamps-rfc7030est-clarify-07-secdir-lc-meadows-2020-07-06-00

Request Review of draft-ietf-lamps-rfc7030est-clarify
Requested rev. no specific revision (document currently at 09)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-07-09
Requested 2020-06-25
Authors Michael Richardson, Thomas Werner, Wei Pan
Draft last updated 2020-07-06
Completed reviews Genart Last Call review of -08 by Ines Robles (diff)
Opsdir Last Call review of -07 by Joel Jaeggli (diff)
Secdir Last Call review of -07 by Catherine Meadows (diff)
Assignment Reviewer Catherine Meadows
State Completed
Review review-ietf-lamps-rfc7030est-clarify-07-secdir-lc-meadows-2020-07-06
Posted at https://mailarchive.ietf.org/arch/msg/secdir/BNd06F7pXbnmRcl9el9BY6DlY4U
Reviewed rev. 07 (document currently at 09)
Review result Has Nits
Review completed: 2020-07-06

Review
review-ietf-lamps-rfc7030est-clarify-07-secdir-lc-meadows-2020-07-06

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  Document editors and WG chairs should treat these comments just like any other comments. 

This draft sets forth changes to the syntax of Enrollment over Secure Transport (EST) (RFC7030) to fix some errors and ambiguities that resulted in interoperability issues.  RFC7030 also includes a form of header that has been deprecated in other RFC’s.  This document thus deprecates that header as well.

Since the only changes to the draft makes to the syntax are either to clarify ambiguities in the descriptions and to deprecate syntax that has already deprecated by other RFC’s, it presents no new security or privacy concerns.  However, I found a few typos, etc. that I am listing below.  They are all of the sort that would be missed by a spell checker.   I don’t know if I got all of them, so I’d suggest another round or proofreading.

I consider this document Ready with Nits.


Abstract

some errata that was reported

should be

some errata that were reported


This document fixes some
   syntactical errors in ASN.1 that was presented

assuming that the word “was” refers to the errors, that should be

This document fixes some
   syntactical errors in ASN.1 that were presented

In the Privacy Considerations Section

This document does not disclose any additional identifies

should be

This document does not disclose any additional identities