Early Review of draft-ietf-lime-yang-connection-oriented-oam-model-03
review-ietf-lime-yang-connection-oriented-oam-model-03-yangdoctors-early-moberg-2018-01-22-00
| Request | Review of | draft-ietf-lime-yang-connection-oriented-oam-model-01 |
|---|---|---|
| Requested revision | 01 (document currently at 07) | |
| Type | Early Review | |
| Team | YANG Doctors (yangdoctors) | |
| Deadline | 2018-01-10 | |
| Requested | 2017-12-13 | |
| Requested by | Mehmet Ersue | |
| Authors | Deepak Kumar , Qin Wu , Zitao Wang | |
| Draft last updated | 2018-01-22 | |
| Completed reviews |
Yangdoctors Early review of -03
by
Carl Moberg
(diff)
Opsdir Last Call review of -05 by Joe Clarke (diff) Genart Last Call review of -05 by Paul Kyzivat (diff) Secdir Last Call review of -05 by Sandra L. Murphy (diff) |
|
| Comments |
Carl Moberg reviewed earlier draft-ietf-lime-yang-oam-model, which is now replaced by draft-ietf-lime-yang-connection-oriented-oam-model. Carl should review again. |
|
| Assignment | Reviewer | Carl Moberg |
| State | Completed | |
| Review |
review-ietf-lime-yang-connection-oriented-oam-model-03-yangdoctors-early-moberg-2018-01-22
|
|
| Reviewed revision | 03 (document currently at 07) | |
| Result | On the Right Track | |
| Completed | 2018-01-22 |
review-ietf-lime-yang-connection-oriented-oam-model-03-yangdoctors-early-moberg-2018-01-22-00
This is my review of draft-ietf-lime-yang-connection-oriented-oam-model-03 and the included YANG module. Overall, the document is in reasonable shape but needs more attention around one fundamental aspect, and a short list of minor issues. My understanding is that this module is intended to be implemented as a network service model, per the module classification RFC (RFC8199). But e.g. the ‘mip' list has a key 'interface' of type 'if:interface-ref'. That type is defined in ietf-interfaces to be a leafref with path "/if:interfaces/if:interface/if:name” assuming that the module context is a single network element. This seems self-contradicting and needs to be resolved. I would suggest running the YANG module through 'pyang -f yang' to provide consistent formatting of the module. I think it would also be worth considering putting the content in the canonical order. E.g. the location of the description statement in the mip-address grouping makes it hard to read. The 'session' list is 'ordered-by user', but does not provide any description or explanation to the meaning of the order. The content of the description strings are in need of language fixes.