Last Call Review of draft-ietf-lsr-flex-algo-bw-con-17
review-ietf-lsr-flex-algo-bw-con-17-genart-lc-holmberg-2024-12-19-00

Request Review of draft-ietf-lsr-flex-algo-bw-con
Requested revision No specific revision (document currently at 22)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-12-17
Requested 2024-12-03
Authors Shraddha Hegde , William Britto , Rajesh Shetty , Bruno Decraene , Peter Psenak , Tony Li
I-D last updated 2024-12-19
Completed reviews Rtgdir Last Call review of -08 by Stewart Bryant (diff)
Tsvart Last Call review of -17 by Marcus Ihlar (diff)
Genart Last Call review of -17 by Christer Holmberg (diff)
Opsdir Telechat review of -18 by Jürgen Schönwälder (diff)
Assignment Reviewer Christer Holmberg
State Completed
Request Last Call review on draft-ietf-lsr-flex-algo-bw-con by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/Q4hBhmHSd4F94C20iic8gfRmE0k
Reviewed revision 17 (document currently at 22)
Result Ready w/nits
Completed 2024-12-19
review-ietf-lsr-flex-algo-bw-con-17-genart-lc-holmberg-2024-12-19-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-lsr-flex-algo-bw-con-17
Reviewer: Christer Holmberg
Review Date: 2024-12-19
IETF LC End Date: 2024-12-17
IESG Telechat date: 2025-02-06

Summary: I have no technical comments or questions. However, I do have one
editorial question/comment that I'd like the authors to address.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

The "Flex-Algorithm" is used throughout the document, and Section 1 contains
the following sentence:

   "A Flex-Algorithm [RFC9350] is defined as a
   set of parameters consisting of calculation-type, metric-type, and a
   set of constraints to allow operators to have more control over the
   network path computation."

Is this correct? Isn't that the definition for FAD? Flex-Algorithm is just a
numeric identifier.

  "In this document, we define further
   extensions to Flex-Algorithm that will allow operators additional
   control over their traffic flows, especially with respect to
   bandwidth constraints."

Similar to the previous comment, in what way is Flex-Algorithm extended,
assuming it is just an identifier?