Early Review of draft-ietf-lsr-isis-flex-algo-yang-00
review-ietf-lsr-isis-flex-algo-yang-00-yangdoctors-early-vasko-2025-08-29-00

Request Review of draft-ietf-lsr-isis-flex-algo-yang
Requested revision No specific revision (document currently at 08)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2025-09-01
Requested 2025-08-17
Requested by Christian Hopps
Authors Yingzhen Qu , Acee Lindem , Madhavi Joshi
I-D last updated 2026-04-30 (Latest revision 2026-04-30)
Completed reviews Rtgdir Early review of -00 by Shuping Peng (diff)
Yangdoctors Early review of -00 by Michal Vaško (diff)
Genart IETF Last Call review of -05 by Russ Housley (diff)
Opsdir IETF Last Call review of -06 by Adrian Farrel (diff)
Comments 
This document was split out from https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-yang-augmentation-v1/ and is being prepared for WGLC
Assignment Reviewer Michal Vaško
State Completed
Request Early review on draft-ietf-lsr-isis-flex-algo-yang by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/fLbZVWJzcjreVnq414RjSSwVhuE
Reviewed revision 00 (document currently at 08)
Result Ready w/issues
Completed 2025-08-29
review-ietf-lsr-isis-flex-algo-yang-00-yangdoctors-early-vasko-2025-08-29-00
Looking at the 2 YANG modules, they are in a good shape and I found only a few
nits (without having knowledge of the ISIS routing protocol). However, the XML
and JSON example YANG data are invalid, which needs to be addressed.

ietf-isis-link-attr
- leaf udabm-length - 2nd line of description has extra space
- leaf transition - 2nd line of description has extra space
- leaf unidirectional-link-delay - units mentioned in description instead of
"units" statement - uses application-specific-link-attributes-sub-tlv - second
usage has extra indent

ietf-isis-flex-algo
- leaf flex-algo - range in description instead of using the "range" statement
- leaf algo-number - redundant range mentioned in the description

Appendix A invalid (yanglint used):
- none of the XML prefixes of the used identities are defined
- there are leafrefs to the ietf-te module data, which should ideally be
included so that the examples can successfully be validated or at least the
used ietf-te data referenced, if found in another RFC - "At least one
area-address must be configured."
(/ietf-routing:routing/control-plane-protocols/control-plane-protocol[type='ietf-isis:isis'][name='default']/ietf-isis:isis)

Appendix B invalid:
- some of the prefixes used are not valid module names (iana-metric-type and
iana-algo-types) - similar leafref problems - similar explicit validation error
message