Last Call Review of draft-ietf-lsr-ospf-terminology-03
review-ietf-lsr-ospf-terminology-03-secdir-lc-leiba-2023-04-20-00
Request | Review of | draft-ietf-lsr-ospf-terminology |
---|---|---|
Requested revision | No specific revision (document currently at 09) | |
Type | Last Call Review | |
Team | Security Area Directorate (secdir) | |
Deadline | 2023-05-03 | |
Requested | 2023-04-19 | |
Authors | Mike Fox , Acee Lindem , Alvaro Retana | |
I-D last updated | 2023-04-20 | |
Completed reviews |
Secdir Last Call review of -03
by Barry Leiba
(diff)
Genart Last Call review of -05 by Gyan Mishra (diff) Intdir Telechat review of -09 by Dirk Von Hugo Rtgdir Last Call review of -03 by Susan Hares (diff) |
|
Assignment | Reviewer | Barry Leiba |
State | Completed | |
Request | Last Call review on draft-ietf-lsr-ospf-terminology by Security Area Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/secdir/tZMRXS7c1lxr4Th8_2BBfd-5Y60 | |
Reviewed revision | 03 (document currently at 09) | |
Result | Has nits | |
Completed | 2023-04-20 |
review-ietf-lsr-ospf-terminology-03-secdir-lc-leiba-2023-04-20-00
I understand why it’s easier to do a single document with a batch update, but I question whether anyone will pay attention to it. Still, until the relevant documents are organically replaced and these changes are actually folded into them, this will serve as a placeholder and reminder of the changes that need to be made. (As a side issue, I wonder if, as we move toward incorporating verified errata reports into the display of RFCs, it might make sense to file these also as errata reports, as this update will not show in such a display.) I have only one substantive comment: — Section 8 — Packet reception and dropping on an interface not configured with the packet AF, e.g., IPv4 is possible because a router that doesn't support this specification can still be included in the SPF calculated path as long as it establishes adjacencies using the Instance ID corresponding to the IPv4 AF. In the conversion away from “black holing”, this sentence became much longer and somewhat convoluted. I urge you to do some further rework, including splitting it into two sentences for clarity.