Last Call Review of draft-ietf-lsr-yang-isis-reverse-metric-01
review-ietf-lsr-yang-isis-reverse-metric-01-yangdoctors-lc-lhotka-2020-12-16-00
| Request | Review of | draft-ietf-lsr-yang-isis-reverse-metric |
|---|---|---|
| Requested revision | No specific revision (document currently at 06) | |
| Type | Last Call Review | |
| Team | YANG Doctors (yangdoctors) | |
| Deadline | 2020-12-18 | |
| Requested | 2020-11-30 | |
| Requested by | Acee Lindem | |
| Authors | Christian Hopps | |
| Draft last updated | 2020-12-16 | |
| Completed reviews |
Yangdoctors Last Call review of -01
by
Ladislav Lhotka
(diff)
Rtgdir Last Call review of -01 by Michael Richardson (diff) Secdir Last Call review of -04 by Hilarie Orman (diff) Genart Last Call review of -04 by Vijay K. Gurbani (diff) |
|
| Assignment | Reviewer | Ladislav Lhotka |
| State | Completed | |
| Review |
review-ietf-lsr-yang-isis-reverse-metric-01-yangdoctors-lc-lhotka-2020-12-16
|
|
| Posted at | https://mailarchive.ietf.org/arch/msg/yang-doctors/rP7dy7wQ71-WUrgkKCXnZjqtvt8 | |
| Reviewed revision | 01 (document currently at 06) | |
| Result | Ready with Issues | |
| Completed | 2020-12-16 |
review-ietf-lsr-yang-isis-reverse-metric-01-yangdoctors-lc-lhotka-2020-12-16-00
**** General comments
- YANG module "ietf-isis-reverse-metric" is in a good shape except for
one issue described below.
- I appreciate the three examples of instance data in appendices (two
in XML representation, one in JSON).
**** Specific comments
- In three places, the module uses "when" expressions with plain
string equality test applied to identityref values, such as:
when "../rt:type = 'isis:isis'"
This is known to be fragile, which can demonstrated on the JSON
example in appendix A.3: It has
"type": "ietf-isis:isis"
which makes the "when" expression false because of the different
prefix, and the corresponding augment doesn't happen.
The above "when" expression should use the XPath function
"derived-from-or-self" that is defined in RFC 7950:
when "derived-from-or-self(../rt:type, 'isis:isis')"
- The "tlv16-reverse-metric" grouping is used only once in the
module. Unless it is expected to be used elsewhere, I would
recommend to remove this grouping and use its contents directly.
- The phrase "YANG XML data" is somewhat misleading, although it is
probably often used in informal discussions. I would suggest "XML
instance data" instead.
**** Nits
- Abstract & Introduction: s/routeing/routing/
- Appending A.3: s/YANG XML data/JSON instance data/