Early Review of draft-ietf-mboned-cbacc-02
|Requested revision||02 (document currently at 04)|
|Team||YANG Doctors (yangdoctors)|
|Requested by||Lenny Giuliano|
|I-D last updated||2021-04-11|
Yangdoctors Early review of -02
by Reshad Rahman
Recommend cluster review of draft-ietf-mboned-cbacc-02 and draft-ietf-mboned-dorms-01 as they are companion docs with shared concepts.
|Reviewed revision||02 (document currently at 04)|
YANG Doctor review of rev-02 by Reshad Rahman. Comments/questions: The document and YANG module-name have CBACC, yet the module prefix is "ambi", is this on purpose? Intuitively, I was expecting the prefix to be "cbacc". For presence statement, use CBACC-enabled instead of cbacc-enabled? Is max-mss for a TCP Max Segment Size, or is this really max packet size? And no need for jumbograms since this is for UDP? Consider renaming max-bits-per-second to something along the lines of max-speed. Description says kilobits (not bits). Add "unit" statement e.g. to data-rate-window and max-bits-per-second OOC, why so many priorities? I'm used to seeing 3 or 8 bits for priority. Security considerations should mention the YANG data nodes. Regards, Reshad.