Skip to main content

Early Review of draft-ietf-mpls-mna-requirements-12
review-ietf-mpls-mna-requirements-12-rtgdir-early-hares-2024-04-21-00

Request Review of draft-ietf-mpls-mna-requirements-11
Requested revision 11 (document currently at 16)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2024-03-31
Requested 2024-03-06
Requested by Adrian Farrel
Authors Matthew Bocci , Stewart Bryant , John Drake
I-D last updated 2024-04-21
Completed reviews Rtgdir Early review of -14 by Andrew Alston (diff)
Secdir Early review of -13 by Dan Harkins (diff)
Genart Last Call review of -13 by Susan Hares (diff)
Rtgdir Early review of -12 by Susan Hares (diff)
Rtgdir Early review of -05 by Sasha Vainshtein (diff)
Comments
This is an "early" to coincide with a second WG last call.

Please assign a new reviewer rather than passing it back to Sasha.
Please assign someone who is not showing as active in the MPLS WG
Assignment Reviewer Susan Hares
State Completed
Request Early review on draft-ietf-mpls-mna-requirements by Routing Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/ZRvf4I4k81sZcsOUSaN20ddzf90
Reviewed revision 12 (document currently at 16)
Result Has nits
Completed 2024-04-21
review-ietf-mpls-mna-requirements-12-rtgdir-early-hares-2024-04-21-00
Status: Ready with NITS

Summary: No Technical issues were found when examined with:
- draft-ietf-mpls-mna-usecases-04
- draft-ietf-mpls-mna-fwk-07

One technical suggestion:
I think more of the MNA framework security consideration should be pulled into
this document to cover: - current network boundaries using filters that form a
trust boundary, - differences with new boundaries that impact that trust
boundary.

By reference of draft-ietf-mpls-mna-fwk, one can find the technical material.
However, a bit more in the text would help the reader.

MPLS-chairs,
Thank you for your patience in waiting for this early review.
Sue

=====================
NITS
1. Requirement #33
Why: Grammar and sentence clarity
Old text:/
   33.  NAIs MUST only be inserted at LSRs that push a label onto the
        stack, e.g. head end LSRs and points of local repair (PLR), but
        can be processed by LSRs along the path of the LSP./

comment: The text
"/, the use of ".e.g. head end LSR and points of local report (PLR), /

is confusing and difficult to read.  Consider rewriting the sentence.

#2 Requirement #39.
Why: Grammar and sentence clarity - the "i.e." detracts from clarity without
adding value. Text:/
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the packet i.e. in-stack or post-stack.
     /
Suggested New text:/
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the packet i.e. in-stack or post-stack.
     /

#3 Requirement #47
Why: Grammar and sentence clarity. "inserting" and "that"
Current text:/
   47.  An MNA solution MUST allow an LER inserting ancillary data to
        determine that each node that needs to process the ancillary
        data can read the required distance into the packet at that node
        (compare with the mechanism in [RFC9088])./
Suggested text:/
   47.  An MNA solution MUST allow an LER that inserts ancillary data to
        determine whether each node that needs to process the ancillary
        data can read the required distance into the packet at that node
        (compare with the mechanism in [RFC9088])./

#4: Section 5, paragraph 2, second sentence
Why: Grammar - Commas in sentence make it difficult to read, "labelled"
(spelling ?).

Current text:/
   Furthermore, an LSR may insert information into the
   labelled packet such that the forwarding behavior is no longer purely
   a function of the top label, or other label with forwarding context,
   but instead is the result of a more complex heuristic./

Perhaps consider a rewrite.
New text:/
   An LSR may insert information into a label packet such that the
   forwarding behavior is no longer a function of either the top label or
   another label within the forwarding context, but a result
   complex heuristic. /

Thank you for your patience in receiving this early