Skip to main content

Last Call Review of draft-ietf-mpls-mna-requirements-13
review-ietf-mpls-mna-requirements-13-genart-lc-hares-2024-04-30-00

Request Review of draft-ietf-mpls-mna-requirements
Requested revision No specific revision (document currently at 16)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-05-06
Requested 2024-04-22
Authors Matthew Bocci , Stewart Bryant , John Drake
I-D last updated 2024-04-30
Completed reviews Rtgdir Early review of -14 by Andrew Alston (diff)
Secdir Early review of -13 by Dan Harkins (diff)
Genart Last Call review of -13 by Susan Hares (diff)
Rtgdir Early review of -12 by Susan Hares (diff)
Rtgdir Early review of -05 by Sasha Vainshtein (diff)
Assignment Reviewer Susan Hares
State Completed
Request Last Call review on draft-ietf-mpls-mna-requirements by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/TOEu7cMA0cwAPOeD2hPPOyK36hg
Reviewed revision 13 (document currently at 16)
Result Ready w/nits
Completed 2024-04-30
review-ietf-mpls-mna-requirements-13-genart-lc-hares-2024-04-30-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-mpls-mna-requirements-??
Reviewer: Susan Hares
Review Date: 2024-04-30
IETF LC End Date: 2024-05-06
IESG Telechat date: Not scheduled for a telechat

Summary: The content of the document provides a clear set of requirements.
Based on my understanding of the MPLS WG discussion on this topic,
these requirements are an accurate discussion of the requirements
desired by the Wg.

Major issues: None

Minor issues: None

Nits/editorial comments:
3 editorial comments based on English grammar and readability of text.

#1, Section 3.4, item 28
Problem: Spelling error
Old text:/
   28.  An MNA solution SHOULD support NAIs for both Pint-to-Point (P2P)
        and Point-to-Multipoint (P2MP) paths, but a specific NAI MAY be
        limited by the network action specification to only one or the
        other of these path types if there is a clear reason to do so./

New text:/
   28.  An MNA solution SHOULD support NAIs for both Point-to-Point (P2P)
        and Point-to-Multipoint (P2MP) paths, but a specific NAI MAY be
        limited by the network action specification to only one or the
        other of these path types if there is a clear reason to do so./

#2 Section 3.4, item 33
Problem: Two grammar issues.
1) e.g. - is normally followed by a comman ("e.g.,). The sentence structure
makes that difficult or impossible. 2. The sentences would be better split into
two pieces.

Current text: /
   33.  NAIs MUST only be inserted at LSRs that push a label onto the
        stack, e.g. head end LSRs and points of local repair (PLR), but
        can be processed by LSRs along the path of the LSP.
/
New test:/
Current text: /
   33.  NAIs MUST only be inserted at LSRs that push a label onto the
        stack but can be processed by LSRs along the path of the LSP.
        Two examples of LSRs that push a label onto the stack are
        the head end LSRs and points of local repair (PLR),
/

#3, section 3.4, item 39.
Problem: Grammar and Punctuation - The "i.e." in the sentence needs a "i.e.,".
Two options are given for resolution.

Current text: /
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the MPLS packet i.e. in-stack or post-
        stack./
Resolution suggestion 1: /
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the MPLS packet - i.e., in-stack or post-
        stack./
Resolution suggestion 2: /
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the MPLS packet, that is in-stack or post-
        stack./