Skip to main content

Last Call Review of draft-ietf-mpls-p2mp-bfd-08
review-ietf-mpls-p2mp-bfd-08-opsdir-lc-wu-2025-01-02-00

Request Review of draft-ietf-mpls-p2mp-bfd
Requested revision No specific revision (document currently at 09)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2024-12-17
Requested 2024-11-26
Requested by Jim Guichard
Authors Greg Mirsky , Gyan Mishra , Donald E. Eastlake 3rd
I-D last updated 2025-01-02
Completed reviews Rtgdir Last Call review of -06 by Joel M. Halpern (diff)
Rtgdir Last Call review of -08 by Darren Dukes (diff)
Genart Last Call review of -08 by Meral Shirazipour (diff)
Secdir Last Call review of -08 by Chris M. Lonvick (diff)
Opsdir Last Call review of -08 by Bo Wu (diff)
Assignment Reviewer Bo Wu
State Completed
Request Last Call review on draft-ietf-mpls-p2mp-bfd by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/BcrCmaaiUEdDNRqpNwv-pCo1zy8
Reviewed revision 08 (document currently at 09)
Result Has nits
Completed 2025-01-02
review-ietf-mpls-p2mp-bfd-08-opsdir-lc-wu-2025-01-02-00
Hi,

I am the assigned OPS reviewer.

Thanks for the document. I have reviewed the version 08 draft, and the overall
structure and descriptions are clear.

This document defines extensions to the Bidirectional Forwarding Detection
(BFD) protocol for Multipoint Networks as described in RFC 8562, with a focus
on MPLS and SR p2mp multipoint networks. The updates include the definition of
a new MPLS G-ACh channel type for Multipoint BFD Session identity, as well as
updates to IP encapsulation definitions, bootstrapping, and specific operations.

Here are some minor comments:

1) Section 2.1. Terminology
It is recommended to rearrange the terms in alphabetical order for better
readability.

2) Section 3.1 IP Encapsulation of Multipoint BFD

"[RFC8562] defines IP/UDP encapsulation for multipoint BFD over p2mp MPLS LSP.
This document updates [RFC8562] regarding the selection of the IPv6 destination
address:"

It is suggested to include the specific section of RFC 8562 as context, as it
is not immediately clear which sections of RFC 8562 need to be updated.

3) Section 3.2 Non-IP Encapsulation of Multipoint BFD

This section states that a new G-ACh channel type value is needed for the
identity of multipoint BFD session.

As mentioned above, it is recommended to reference the specific sections of RFC
8562, such as 5.7. Discriminators and Packet Demultiplexing. Additionally, the
new channel type value is currently defined as TBA1; it would be helpful to
name this value or expand on what TBA1 stands for.

4) Section 5. Operation of Multipoint BFD with Active Tail over P2MP MPLS LSP

“The notifications from leaves to the root will not use DetNet resources and,
as a result, will not congest DetNet flows, although they may negatively affect
other flows.”

In this text, the term "DetNet resource" is not referenced, and it's unclear
why DetNet is specified here. Is it necessary to limit the discussion to
DetNet, or could it apply to other network types as well?

Thanks,
Bo Wu