Last Call Review of draft-ietf-mpls-p2mp-lsp-ping-
review-ietf-mpls-p2mp-lsp-ping-tsvdir-lc-scharf-2011-06-01-00

Request Review of draft-ietf-mpls-p2mp-lsp-ping
Requested rev. no specific revision (document currently at 18)
Type Last Call Review
Team Transport Area Directorate (tsvdir)
Deadline 2011-05-30
Requested 2011-05-18
Other Reviews Secdir Last Call review of - by Carl Wallace (diff)
Review State Completed
Reviewer Michael Scharf
Review review-ietf-mpls-p2mp-lsp-ping-tsvdir-lc-scharf-2011-06-01
Posted at http://www.ietf.org/mail-archive/web/ietf/current/msg66558.html
Draft last updated 2011-06-01
Review completed: 2011-06-01

Review
review-ietf-mpls-p2mp-lsp-ping-tsvdir-lc-scharf-2011-06-01

Hello,

I've reviewed this document as part of the transport area directorate's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the
document's authors for their information and to allow them to address
any issues raised. The authors should consider this review together with
any other last-call comments they receive. Please always CC
tsv-dir at ietf.org if you reply to or forward this review.

Disclaimer: Please note that I am a transport protocol researcher and
thus not familiar with details of the MPLS OAM mechanisms.

This draft is basically ready for publication, but there is an issue
that should be fixed before publication. 


Content:
--------

The LSP ping relies on the "Echo Jitter TLV" to deal with the implosion
of feedback messages, which is important in order to avoid congestion.
However, there seems to be a SHOULD/MUST mismatch concerning the
required reaction:

- Section 3.3: "A responding node SHOULD wait a random amount of time
between zero milliseconds and the value specified in this field."

- Section 4.1.2: "If this TLV is present, the responding LSR MUST delay
sending a response for a random amount of time between zero milliseconds
and the value indicated in the TLV."



Editorial:
----------

Section 4.2.1.3:  s/like an combination/like a combination/



Best regards

Michael