Last Call Review of draft-ietf-mpls-rfc3107bis-02
review-ietf-mpls-rfc3107bis-02-rtgdir-lc-bryant-2017-06-27-00
Request | Review of | draft-ietf-mpls-rfc3107bis |
---|---|---|
Requested revision | No specific revision (document currently at 04) | |
Type | Last Call Review | |
Team | Routing Area Directorate (rtgdir) | |
Deadline | 2017-06-16 | |
Requested | 2017-05-30 | |
Requested by | Deborah Brungard | |
Authors | Eric C. Rosen | |
I-D last updated | 2017-06-27 | |
Completed reviews |
Rtgdir Early review of -01
by Jonathan Hardwick
(diff)
Rtgdir Last Call review of -02 by Stewart Bryant (diff) Genart Last Call review of -02 by Brian E. Carpenter (diff) |
|
Comments |
Prep for Last Call - prefer Stewart if he can do it. |
|
Assignment | Reviewer | Stewart Bryant |
State | Completed | |
Review |
review-ietf-mpls-rfc3107bis-02-rtgdir-lc-bryant-2017-06-27
|
|
Reviewed revision | 02 (document currently at 04) | |
Result | Ready | |
Completed | 2017-06-27 |
review-ietf-mpls-rfc3107bis-02-rtgdir-lc-bryant-2017-06-27-00
Firstly my apologies for the lateness of this review. This is a very well written draft, and can proceed as is. Useful clarity might be added to Section 4 (dataplane) by the inclusion of some figures. I say this as someone that finds it easier to take in information in that format, so that is a personal preference comment, the text is correct and technically sufficient. There is an intriguing piece of text in the dataplane section "While this may be useful in certain scenarios, it may provide unintended results in other scenarios." which I think might be usefully expanded to give at least one example of a use, and an unintended consequence. In the introduction it says: "In [RFC3107], this feature was controlled by a BGP Capability Code that has never been implemented, and is now essentially obsolete." which left me wondering whether there was the intention to formally deprecate the feature through the RFC system.