IETF Last Call Review of draft-ietf-netconf-adaptive-subscription-14
review-ietf-netconf-adaptive-subscription-14-yangdoctors-lc-clarke-2026-01-22-01

Request Review of draft-ietf-netconf-adaptive-subscription
Requested revision No specific revision (document currently at 18)
Type IETF Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2026-01-16
Requested 2025-12-31
Requested by Mahesh Jethanandani
Authors Qin Wu , Peng Liu , Qiufang Ma , Wei Wang , Zhixiong Niu
I-D last updated 2026-05-20 (Latest revision 2026-04-22)
Completed reviews Yangdoctors Early review of -07 by Joe Clarke (diff)
Opsdir Early review of -08 by Dhruv Dhody (diff)
Yangdoctors IETF Last Call review of -14 by Joe Clarke (diff)
Opsdir IETF Last Call review of -14 by Dhruv Dhody (diff)
Tsvart IETF Last Call review of -15 by Dr. Joseph D. Touch (diff)
Secdir IETF Last Call review of -15 by Yoav Nir (diff)
Comments 
Thanks first of all to Dhruv for the OPSDIR review and to Joe for the YANG Doctors review. The last version they reviewed was -08. We are at -14. A quick check from them would be helpful before I request an IESG evaluation.
Assignment Reviewer Joe Clarke
State Completed
Request IETF Last Call review on draft-ietf-netconf-adaptive-subscription by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/smcV1GRKvMBv66FJTsrFAmgv1d4
Reviewed revision 14 (document currently at 18)
Result Ready w/nits
Completed 2026-01-22
review-ietf-netconf-adaptive-subscription-14-yangdoctors-lc-clarke-2026-01-22-01
I've been asked to re-review this document on behalf of YANG Doctors.  I'm
pleased to say that all of my previous comments have been addressed
satisfactorily.  Overall, the document's YANG matter is in good shape.  I did
find a few nits, though.

In Section 2.4:

s/has been switched based its/has been switched based on its/

Section Appendix C.4:

s/and adjust the update interval/and adjusts the update interval/

In the description for the eval-expression leaf:

s/the updates are only pushed as/the updates are only pushed at/

In the description for the eval-interval leaf, you call XPath Xpath and you
don't mention the name, "eval-expression" whereas you have made this effort in
other leafs (yeah, I said leafs).

In the description for the adaptive-period-update notification, you have the
same missed "on" that you had in Section 2.4.

In Section 5.1, you have a run-on sentence:

XPath evaluation criteria are applied against a minimal set of data nodes in
the data model, the minimal set of data nodes can be advertised...

Maybe, put a period after "data model"?

Those are the nits, but I do have a suggestion.  With respect to the
evaluation-interval-unsupported RPC error, I think an example of the
supplemental information hint might be nice.