Last Call Review of draft-ietf-netconf-trace-ctx-extension-01
review-ietf-netconf-trace-ctx-extension-01-opsdir-lc-mishra-2024-10-28-00
Request | Review of | draft-ietf-netconf-trace-ctx-extension |
---|---|---|
Requested revision | No specific revision (document currently at 02) | |
Type | Last Call Review | |
Team | Ops Directorate (opsdir) | |
Deadline | 2024-10-16 | |
Requested | 2024-10-03 | |
Requested by | Per Andersson | |
Authors | Roque Gagliano , Kristian Larsson , Jan Lindblad | |
I-D last updated | 2024-10-28 | |
Completed reviews |
Yangdoctors Last Call review of -02
by Xufeng Liu
Opsdir Last Call review of -01 by Gyan Mishra (diff) |
|
Assignment | Reviewer | Gyan Mishra |
State | Completed | |
Request | Last Call review on draft-ietf-netconf-trace-ctx-extension by Ops Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/ops-dir/NykE9MCyB-dck8NKaQjINFzceRE | |
Reviewed revision | 01 (document currently at 02) | |
Result | Not ready | |
Completed | 2024-10-28 |
review-ietf-netconf-trace-ctx-extension-01-opsdir-lc-mishra-2024-10-28-00
Summary: This document defines how to propagate trace context information across the Network Configuration Protocol (NETCONF), that enables distributed tracing scenarios. It is an adaption of the HTTP-based W3C specification. I reviewed draft revision -01 and the draft is almost ready for publication but has some minor issue below. Major issue: None Minor issues: Network Configuration Protocol (NETCONF) uses the Secure Shell (SSH) transport layer as its default mechanism using default port 830, SOAP port 833 or HTTP port 832. Abstract recommended change Old: This document defines how to propagate trace context information across the Network Configuration Protocol (NETCONF), that enables distributed tracing scenarios. It is an adaption of the HTTP-based W3C specification.¶ New: This document defines how to propagate trace context information using Network Configuration Protocol (NETCONF) push in order to enable distributed tracing scenarios. It is an adaption of the HTTP-based W3C specification. W3C owns the HTTP specification so how is this draft changing the W3C http specification? Netconf can use http but it’s not changing the http specification correct ? In the introduction see this paragraph The W3C has defined two HTTP headers for context propagation that are useful in use case scenarios of distributed systems like the ones defined in [RFC8309]. This document defines an extension to the NETCONF protocol to add the same concepts and enable trace context propagation over NETCONF. So we are defining an extension to Netconf protocols in section 2 related to W3Cs HTTP specification so in that way is this draft actually updating HTTP specification as well for the two new header types? Nits: None