Last Call Review of draft-ietf-netmod-rfc6991-bis-16
review-ietf-netmod-rfc6991-bis-16-artart-lc-gondwana-2024-09-29-00
Request | Review of | draft-ietf-netmod-rfc6991-bis |
---|---|---|
Requested revision | No specific revision (document currently at 17) | |
Type | Last Call Review | |
Team | ART Area Review Team (artart) | |
Deadline | 2024-10-08 | |
Requested | 2024-09-24 | |
Authors | Jürgen Schönwälder | |
I-D last updated | 2024-09-29 | |
Completed reviews |
Yangdoctors Last Call review of -16
by Martin Björklund
(diff)
Opsdir Last Call review of -16 by Giuseppe Fioccola (diff) Secdir Last Call review of -16 by Rifaat Shekh-Yusef (diff) Dnsdir Last Call review of -16 by Florian Obser (diff) Genart Last Call review of -16 by Russ Housley (diff) Artart Last Call review of -16 by Bron Gondwana (diff) Dnsdir Telechat review of -17 by Florian Obser |
|
Assignment | Reviewer | Bron Gondwana |
State | Completed | |
Request | Last Call review on draft-ietf-netmod-rfc6991-bis by ART Area Review Team Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/art/PAj8sI2HAh0QTKluPWLQh6_vync | |
Reviewed revision | 16 (document currently at 17) | |
Result | Not ready | |
Completed | 2024-09-29 |
review-ietf-netmod-rfc6991-bis-16-artart-lc-gondwana-2024-09-29-00
I'm the designated ARTART reviewer for this document. It's generally well written and clear; I didn't see any issues with the document itself, however there are some obsolete references and changes to align with work done elsewhere in the IETF which I believe would improve the overall cross-compatibility of IETF specifications significantly, hence my marking it as "NOT READY". *Date-Time:* While the date-time format duplicates the description found in RFC 6021 and later RFC 6991, the construct -00:00 has been identified as being incompatible with the latest ISO8601 by the work in the SEDATE working group. I would refer you to section 2 of RFC 9557 for the full description and update of RFC 3339 which was done there. I suggest that this document should be updated to align with (and reference) RFC 9557 and deprecate the usage of -00:00; instead using "Z" to mean "local time reference point is unknown" as is common practice. This will improve future interoperability with ISO8601. Likewise the same issue occurs with the new "date" format and "time" format. *Email Address:* The email-address construct in this document is limited to 7-bit. RFC 6531 and RFC 6532 have extended Email Address to allow UTF-8 characters. There's a good analysis of the changes at: https://gist.github.com/baker-ling/3b4b014ee809aa9732f9873fe060c098 Since this is a new datatype being added, it should support all legal email addresses as defined in current IETF RFCs; so be extended for 8 bit local-parts. Similarly, the domain part of the address should explicitly mention A-labels for Internationalized domain names, as the "domain-name" construct does.