Last Call Review of draft-ietf-netmod-rfc8407bis-11
review-ietf-netmod-rfc8407bis-11-yangdoctors-lc-liu-2024-06-17-00
Request | Review of | draft-ietf-netmod-rfc8407bis |
---|---|---|
Requested revision | No specific revision (document currently at 18) | |
Type | Last Call Review | |
Team | YANG Doctors (yangdoctors) | |
Deadline | 2024-06-17 | |
Requested | 2024-06-03 | |
Requested by | Kent Watsen | |
Authors | Andy Bierman , Mohamed Boucadair , Qin Wu | |
I-D last updated | 2024-06-17 | |
Completed reviews |
Yangdoctors Last Call review of -11
by Xufeng Liu
(diff)
|
|
Assignment | Reviewer | Xufeng Liu |
State | Completed | |
Request | Last Call review on draft-ietf-netmod-rfc8407bis by YANG Doctors Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/yang-doctors/QFNwJC99AtorujtQLPtsRQZDVP8 | |
Reviewed revision | 11 (document currently at 18) | |
Result | Ready w/nits | |
Completed | 2024-06-17 |
review-ietf-netmod-rfc8407bis-11-yangdoctors-lc-liu-2024-06-17-00
3.2. Code Components The “file name” after the "<CODE BEGINS>" tag is something described as “SHOULD” be included. If there is no such a “file name”, the tool “rfcstrip” will not extract the correct file. Should we consider making this “file name” a “MUST”? 3.5.1. YANG Module Classification In the section “Network model”, the term "Network model” is described as “relevant protocols operating at the link and network layers”. Can a network model be designed for other layers, such as OTN or MPLS? If so, such a description seems to be too narrow. RFC 8309 clarifies the “Service Model”, which is the section before this one. Is there a definition of the “network model” in RFC 8309? 3.8. IANA Considerations Section The “YANG Module Names” registry is defined in RFC 6020, but not RFC 7950. Many YANG module writers mistakenly used RFC 7950. Should we consider bringing this up with special attention? 4.5. Conditional Statements An example not preferred is given, but there is no preferred fix. Would it be better to provide the proffered solution?