Last Call Review of draft-ietf-netmod-yang-data-ext-05
review-ietf-netmod-yang-data-ext-05-rtgdir-lc-mizrahi-2020-01-30-00

Request Review of draft-ietf-netmod-yang-data-ext
Requested rev. no specific revision (document currently at 05)
Type Last Call Review
Team Routing Area Directorate (rtgdir)
Deadline 2020-01-31
Requested 2019-10-23
Requested by Alvaro Retana
Authors Andy Bierman, Martin Björklund, Kent Watsen
Draft last updated 2020-01-30
Completed reviews Genart Telechat review of -04 by Brian Carpenter (diff)
Rtgdir Last Call review of -05 by Tal Mizrahi
Assignment Reviewer Tal Mizrahi
State Completed
Review review-ietf-netmod-yang-data-ext-05-rtgdir-lc-mizrahi-2020-01-30
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/hOVP1QXGrIYcthTxj2KowQd7HlY
Reviewed rev. 05
Review result Has Nits
Review completed: 2020-01-30

Review
review-ietf-netmod-yang-data-ext-05-rtgdir-lc-mizrahi-2020-01-30

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-netmod-yang-data-ext-05
Reviewer: Tal Mizrahi
Review Date: January 30th, 2020
Intended Status: Standards Track

Summary:
This document is basically ready for publication, but has two minor issues
that should be considered prior to publication.

Comments:
The document is well-written and clear, even to the non-expert reader. The
examples are highly appreciated.

Minor issues:
- The following definition in the "Terminology" section is recursive, and
not very clear at this point in the document (it becomes clearer only after
the "Definitions" section). It would be highly recommended to rephrase this:

'YANG data structure: A data structure defined with the "structure"
statement.'

- The "Definitions" section seems to define a single term, the YANG data
structure. It would be best to rename the section.

Cheers,
Tal Mizrahi.