Skip to main content

IETF Last Call Review of draft-ietf-netmod-yang-module-filename-06
review-ietf-netmod-yang-module-filename-06-opsdir-lc-guo-2026-02-24-00

Request Review of draft-ietf-netmod-yang-module-filename
Requested revision No specific revision (document currently at 07)
Type IETF Last Call Review
Team Ops Directorate (opsdir)
Deadline 2026-03-03
Requested 2026-02-22
Requested by Mohamed Boucadair
Authors Per Andersson
I-D last updated 2026-04-02 (Latest revision 2026-04-02)
Completed reviews Yangdoctors Early review of -00 by Jürgen Schönwälder (diff)
Genart IETF Last Call review of -06 by Joel M. Halpern (diff)
Secdir IETF Last Call review of -06 by Barry Leiba (diff)
Opsdir IETF Last Call review of -06 by Aihua Guo (diff)
Comments
It is OK if the review is received after the deadline. Thanks.
Assignment Reviewer Aihua Guo
State Completed
Request IETF Last Call review on draft-ietf-netmod-yang-module-filename by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/F6O8r5Cq7dYtW4JiP_nbHNkaCrM
Reviewed revision 06 (document currently at 07)
Result Has issues
Completed 2026-02-24
review-ietf-netmod-yang-module-filename-06-opsdir-lc-guo-2026-02-24-00
Hi,

I have been selected as the Operational Directorate (opsdir) reviewer for this
Internet-Draft.

The Operational Directorate reviews all operational and management-related
Internet-Drafts to ensure alignment with operational best practices and that
adequate operational considerations are covered.

A complete set of _"Guidelines for Considering Operations and Management in
IETF Specifications"_ can be found at
https://datatracker.ietf.org/doc/draft-ietf-opsawg-rfc5706bis/.

While these comments are primarily for the Operations and Management Area
Directors (Ops ADs), the authors should consider them alongside other feedback
received.

- Document: draft-ietf-netmod-yang-module-filename

- Reviewer: Aihua Guo

- Review Date: 02-24-2026

- Intended Status: Standards Track

---

## Summary

- Has Issues: This document contains logical inconsistency that should be fixed
prior to publication.

## Major Issues

None.

---

## Minor Issues

As other reviewers already pointed out, Section 2 presents logically
contradicting statements regarding the required format of the module file name
when the YANG module has associated sematic version.

These two (repetitive) statements indicate that a file name with YANG sematic
version is optional, and file with revision date is still acceptable: "If a
revision has an associated YANG semantic version (ysv:version)
   then it MAY use the YANG semantic version instead of the revision
   date in the file name of a YANG file"
and,
"YANG module (or submodule) files MAY be identified using either
   revision-date or YANG semantic version (ysv:version)"

While the following statement says the opposite:
"If the YANG module (or submodule) has an associated YANG semantic
   version (ysv:version), then a file name that use the YANG semantic
   version MUST be used.  In addition, a file with the revision date in
   the file name MAY be created as well."

The document needs to clarify and fix the intended behavior. The document is in
good shape otherwise.

---

## Nits

In Section 1, Introduction

For precision & consistency:
OLD
"This document defines the YANG module file convention"

NEW
"This document defines the YANG module file name convention"

---