Last Call Review of draft-ietf-nfsv4-layrec-01
review-ietf-nfsv4-layrec-01-artart-lc-peng-2024-08-22-00
Request | Review of | draft-ietf-nfsv4-layrec |
---|---|---|
Requested revision | No specific revision (document currently at 01) | |
Type | Last Call Review | |
Team | ART Area Review Team (artart) | |
Deadline | 2024-08-27 | |
Requested | 2024-08-13 | |
Authors | Thomas Haynes , Trond Myklebust | |
I-D last updated | 2024-08-22 | |
Completed reviews |
Artart Last Call review of -01
by Shuping Peng
Genart Last Call review of -01 by Dale R. Worley |
|
Assignment | Reviewer | Shuping Peng |
State | Completed | |
Request | Last Call review on draft-ietf-nfsv4-layrec by ART Area Review Team Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/art/aVzKI5hc2zV5COWrr4DlLCeEnHI | |
Reviewed revision | 01 | |
Result | Ready w/issues | |
Completed | 2024-08-22 |
review-ietf-nfsv4-layrec-01-artart-lc-peng-2024-08-22-00
I am the assigned ART-ART reviewer for this draft. Summary: I have some minor concerns about this document that I think should be resolved before publication. Comments: Major Issues: "No major issues found." Minor Issues: 1.1 Definitions I found that the terms listed here are exactly the same as those defined in RFC8435. So I wonder whether it would make sense to simply refer to RFC8435 instead of repeating them. 2. Layout State Recovery "After the grace period: If the client were to send any lrf_stateid in the LAYOUTRETURN with the anonymous stateid of all zeros, then the metadata server would respond with an error of NFS4ERR_NO_GRACE (see Section 15.1.9.3 of [RFC8881])." I am not sure whether there is an mistake in this sentence: "to send any lrf_stateid in the LAYOUTRETURN with the anonymous stateid of all zeros"? Should "with" be "other than"? 4. IANA Considerations "IANA should use the current document (RFC-TBD) as the reference for the new entries." What are the "new entries" mentioned in this sentence? Would it be clearer to list them here? Nits: None