Skip to main content

Last Call Review of draft-ietf-nfsv4-minorversion2-dot-x-39

Request Review of draft-ietf-nfsv4-minorversion2-dot-x
Requested revision No specific revision (document currently at 41)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2016-01-05
Requested 2015-11-25
Authors Thomas Haynes
I-D last updated 2015-12-14
Completed reviews Genart Last Call review of -39 by Elwyn B. Davies (diff)
Genart Telechat review of -40 by Elwyn B. Davies (diff)
Secdir Last Call review of -39 by Warren "Ace" Kumari (diff)
Assignment Reviewer Elwyn B. Davies
State Completed
Request Last Call review on draft-ietf-nfsv4-minorversion2-dot-x by General Area Review Team (Gen-ART) Assigned
Reviewed revision 39 (document currently at 41)
Result Ready w/nits
Completed 2015-12-14
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at


Document: draft-ietf-nfsv4-minorversion2-dot-x-39.txt
Reviewer: Elwyn Davies
Review Date: 2015-12-13
IETF LC End Date: 2015-12-09
IESG Telechat date: (if known) -

Summary: Ready with nits.  The XDR specification appears to be a 

superset of the v4.1 XDR specification and combines a correction of the 

five remaining discrepancies between v4.1 and v4.0bis ( definition and 

use of the NFS4_OTHER_SIZE constant, addition and use of the 

ascii_REQUIRED4 type, modification of the typedef of linktext4). The 

additions of the 4.2 interface appears to match the specification in 

draft-ietf-nfsv4-minorversion2-39 except for two attribute typedef  

items mentioned below.  One discrepancy would have no operational effect 

as the type used in the other draft  is an alias for the type used here 

but the clone_blksize error changes the size of the type.

I have checked that the extracted code is accepted by rpcgen and 

generates files as expected.

Major issues:

Minor issues:

Nits/editorial comments:

Observation:  It might be useful to note that this XDR specification is 

fully upwards compatible with the v4.0bis with the minor exception of 

the clientaddr4 structure which has been replaced by (strictly, aliased 

to) netaddr4 which has the same members with the same purposes but the 

names have changed (r_netid -> na_r_netid, r_addr ->na_r_addr).  This 

effectively fully reconverges the v4.0bis and v4.1 strands of the XDR.

Line 1145: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 


                    whereas in this draft we 

have                           typedef uint64_t fattr4_space_freed

Line 1149: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 


                    whereas in this draft we 

have                           typedef uint32_t fattr4_clone_blksize