Early Review of draft-ietf-nmop-message-broker-telemetry-message-02
review-ietf-nmop-message-broker-telemetry-message-02-yangdoctors-early-bjorklund-2025-09-30-00

This is my YANG doctor review of draft-ietf-nmop-message-broker-telemetry-message-02.

o  General comment

    The module ietf-telemetry-message
    
      "defines a standard YANG envelope message to carry with
       the collected Network Telemetry notifications the provenance and
       metadata information for a YANG data exchange between between Message
       Broker producers and consumers"
    
    However, the module actually defines operational state data, with the top-level node
    "message".
    
    It is not completely clear to me how this schema is supposed to be
    used, so I don't know which YANG construct to recommend.  Either it
    should be "notification", or probaly "sx:structure" (RFC 8791).


o  identity yp-push

    This would expand to "YANG push push".

    A better name is probably "yang-push".


o  typedef telemetry-notification-event-type

    This typedef isn't used in the module.  Is it defined to be used by other modules?  If
    so it needs more descriptive text that explains how it is supposed to be used.


o  Example

  It would be useful with an example that shows how these modules are supposed to be used;
  e.g., assuming that YANG Push is used as the session protocol to get XXX, show how the
  envelope defined here is used to wrap XXX and how it is sent to Kafka / RabbitMQ etc.



/martin