Last Call Review of draft-ietf-ntp-yang-data-model-12
review-ietf-ntp-yang-data-model-12-genart-lc-evens-2021-02-12-00

Request Review of draft-ietf-ntp-yang-data-model
Requested revision No specific revision (document currently at 17)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2021-02-12
Requested 2021-01-29
Authors Nan Wu , Dhruv Dhody , Ankit kumar Sinha , ANIL KUMAR S N , Yi Zhao
I-D last updated 2021-02-12
Completed reviews Yangdoctors Early review of -03 by Andy Bierman (diff)
Yangdoctors Early review of -10 by Andy Bierman (diff)
Secdir Last Call review of -10 by Takeshi Takahashi (diff)
Genart Last Call review of -12 by Tim Evens (diff)
Assignment Reviewer Tim Evens
State Completed
Request Last Call review on draft-ietf-ntp-yang-data-model by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/MWJ2KyDkHBYqN-IA9gKpsHGC7yo
Reviewed revision 12 (document currently at 17)
Result Ready w/nits
Completed 2021-02-12
review-ietf-ntp-yang-data-model-12-genart-lc-evens-2021-02-12-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ntp-yang-data-model-??
Reviewer: Tim Evens
Review Date: 2021-02-12
IETF LC End Date: 2021-02-12
IESG Telechat date: Not scheduled for a telechat

Summary:
Overall, nice document.

Major issues:

Minor issues:

Nits/editorial comments:

Spelling correction; s/retriving/retrieving/g

It appears that "bb1d6929 e9593728 7fa37d12 9b756746" is not correctly enclosed
in xml. The key/hexadecimal-string declares it correctly, but the space
delimited string seems out of place.

"""
    <config>
       <ntp xmlns="urn:ietf:params:xml:ns:yang:ietf-ntp">
         <authentication>
           <auth-enabled>true</auth-enabled>
           <authentication-keys>
             <key-id>10</key-id>
             <algorithm>aes-cmac</algorithm>
             bb1d6929 e9593728 7fa37d12 9b756746
             <key>
               <hexadecimal-string>
                 bb1d6929e95937287fa37d129b756746
               </hexadecimal-string>
             </key>
             <istrusted>true</istrusted>
           </authentication-keys>
         </authentication>
       </ntp>
     </config>
"""

Are the backslashes required here? It seems that many examples have them when
there is a value and the closing tag is not on the same line.  For example:

"""
 <data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
     <ntp xmlns="urn:ietf:params:xml:ns:yang:ietf-ntp">
       <clock-state>
         <system-status>
           <clock-state>synchronized</clock-state>
           <clock-stratum>7</clock-stratum>
           <clock-refid>192.0.2.1</clock-refid>
           <associations-address>192.0.2.1\
           </associations-address>
           <associations-local-mode>client\
           </associations-local-mode>
           <associations-isconfigured>yes\
           </associations-isconfigured>
           <nominal-freq>100.0</nominal-freq>
           <actual-freq>100.0</actual-freq>
           <clock-precision>18</clock-precision>
           <clock-offset>0.025</clock-offset>
           <root-delay>0.5</root-delay>
           <root-dispersion>0.8</root-dispersion>
           <reference-time>10-10-2017 07:33:55.258 Z+05:30\
           </reference-time>
           <sync-state>clock-synchronized</sync-state>
         </system-status>
       </clock-state>
     </ntp>
   </data>
"""