Last Call Review of draft-ietf-nvo3-evpn-applicability-03
|Requested revision||03 (document currently at 05)|
|Type||Last Call Review|
|Team||Routing Area Directorate (rtgdir)|
|Requested by||Andrew Alston|
|Authors||Jorge Rabadan , Matthew Bocci , Sami Boutros , Ali Sajassi|
|Draft last updated||2022-06-02|
Rtgdir Last Call review of -03
by Mach Chen
Opsdir Last Call review of -04 by Scott O. Bradner (diff)
Genart Last Call review of -04 by Reese Enghardt (diff)
Secdir Last Call review of -04 by Kyle Rose (diff)
Requesting review before going into last call.
|Reviewed revision||03 (document currently at 05)|
Comments: This document is well-written and easy to read. It gives a detail introduction on how to apply EVPN to NVO3 networks. Nits: 1. Section 4.2, Figure 1 Where the BD1 is depicted as part of MAC-VRF1, but according to the definition of BD and MAC-VRF, there should not be inclusion relationship between BD and MAC-VRF. To avoid confusion, I'd suggest to remove the MAC-VRF1 from NVE1. In addition, Figure uses "-" and "=" to describe active ACs, it's better to use either "-" or "=", instead of using both. In addition, suggest to add a reference to MP-BGP. 2. Section 4.2.1, Suggest to add a reference to LACP. 3. Section 4.2.2, OLD: "In the example of Figure 1, when MAC-VRF1/BD1 are enabled, NVE1 will send an RT-3 including its own IP address, Ethernet-Tag for BD1 and the PTA. Assuming Ingress Replication (IR), the RT-3 will include an identification for IR in the PTA and the VNI the NVEs must use to send BUM traffic to the advertising NVE." New: "In the example of Figure 1, when MAC-VRF1/BD1 are enabled, NVE1 will send an RT-3 including its own IP address, Ethernet-Tag for BD1 and the PTA to the remote NVEs. Assuming Ingress Replication (IR) is used, the RT-3 will include an identification for IR in the PTA and the VNI that the other NVEs in the BD must use to send BUM traffic to the advertising NVE." s/NVEs participating/the NVEs participating s/RT-3/RT-3 route, it needs to check the whole document for the similar situation, for each RT-x, a "route" should be added after it. 4. Section 4.3 s/Asymmetric and Symmetric/Asymmetric and Symmetric model 5. Section 4.5, The section title, s/EVPN OAM and application to NVO3/EVPN OAM and Application to NVO3, it needs to check the whole document to make sure that that section title adopts consistent style, e.g., upper case for each word. 6. Section 4.6, Is it just in theory or is there an existing extension? If latter, a reference is preferred; otherwise, maybe it can be safely removed or add some text to say that there will be potential work to do. 7. Section 4.7.6, It's better to add "SBD" to the Terminology section and add more text to describe it.