Last Call Review of draft-ietf-opsawg-ntw-attachment-circuit-12
review-ietf-opsawg-ntw-attachment-circuit-12-opsdir-lc-fioccola-2024-08-26-00

Request Review of draft-ietf-opsawg-ntw-attachment-circuit-12
Requested revision 12 (document currently at 13)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2024-08-16
Requested 2024-07-31
Requested by Mahesh Jethanandani
Authors Mohamed Boucadair , Richard Roberts , Oscar Gonzalez de Dios , Samier Barguil , Bo Wu
I-D last updated 2024-08-26
Completed reviews Rtgdir Last Call review of -09 by Gyan Mishra (diff)
Rtgdir Early review of -05 by Gyan Mishra (diff)
Yangdoctors Early review of -04 by Martin Björklund (diff)
Opsdir Last Call review of -12 by Giuseppe Fioccola (diff)
Rtgdir Last Call review of -12 by Joel M. Halpern (diff)
Comments 
I would like both the OPS and RTG Area Directorate's views on the applicability of this YANG module.

In particular, I would like the directorates to comment on Section 5.3, Provisioning Profiles, and their view on the routing-profile-identifiers within the YANG model both from an operations and routing perspective. Note, that the module identifies certain parameters for each routing protocol BGP, OSPF, ISIS, and RIP at a *network* level, not at a device level. That means each AC gets to define its own "routing profile". How is an operator supposed to read (and use) these parameters, considering that the device might have its own configuration for those routing protocols?
Assignment Reviewer Giuseppe Fioccola
State Completed
Request Last Call review on draft-ietf-opsawg-ntw-attachment-circuit by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/J3iqNRinrBK-W2nnK9N3n-yEPO4
Reviewed revision 12 (document currently at 13)
Result Has issues
Completed 2024-08-26
review-ietf-opsawg-ntw-attachment-circuit-12-opsdir-lc-fioccola-2024-08-26-00
This document specifies a network YANG data model for attachment circuits and
this is a really relevant work. There is a group of related documents
(draft-ietf-opsawg-ntw-attachment-circuit, draft-ietf-opsawg-teas-common-ac,
draft-ietf-opsawg-teas-attachment-circuit, draft-ietf-opsawg-ac-lxsm-lxnm-glue)
and their relation is explained in section 3. While I found the document useful
and well-written, it left me with some questions.

From an OPSDIR point of view, I think that some clarification would be helpful.
In particular, I would suggest to add more details about the
specific-provisioning-profiles specifically in section 5.3. It is mentioned
that the exact definition of the specific provisioning profiles is local to
each service provider, but I think that a more complete explanation, possibly
with examples, may help an implementer to better understand how to use these
data nodes. In this regard, it would also be great to describe the usage of the
different identifiers (i.e. encryption-profile-identifier,
qos-profile-identifier, failure-detection-profile-identifier,
forwarding-profile-identifier, routing-profile-identifier) under the
valid-provider-identifiers container. I found some considerations about the
vulnerability of the specific-provisioning-profiles container in the section on
Security Considerations and this is good.