Skip to main content

Early Review of draft-ietf-opsawg-yang-vpn-service-pm-05
review-ietf-opsawg-yang-vpn-service-pm-05-yangdoctors-early-lhotka-2022-04-08-00

Request Review of draft-ietf-opsawg-yang-vpn-service-pm-03
Requested revision 03 (document currently at 08)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2022-03-21
Requested 2022-02-28
Requested by Joe Clarke
Authors Bo Wu , Qin Wu , Mohamed Boucadair , Oscar Gonzalez de Dios , Bin Wen
Draft last updated 2022-04-08
Completed reviews Yangdoctors Early review of -05 by Ladislav Lhotka (diff)
Yangdoctors Last Call review of -07 by Radek Krejčí (diff)
Assignment Reviewer Ladislav Lhotka
State Completed
Review review-ietf-opsawg-yang-vpn-service-pm-05-yangdoctors-early-lhotka-2022-04-08
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/dxtr7HAiIYa7fprTuPbOGCKgZjE
Reviewed revision 05 (document currently at 08)
Result Ready with Nits
Completed 2022-04-08
review-ietf-opsawg-yang-vpn-service-pm-05-yangdoctors-early-lhotka-2022-04-08-00
**** General comments

The Internet-Draft contains a large YANG module that augments the network
topology model with L2/L3 VPN performance monitoring statistics. The module is
well designed and documented, I found no issues in it.

Examples of JSON instance data are useful for readers of the I-D, but less so
if they contain errors (see below). If possible, I'd suggest to validate the
examples with appropriate tools, or at least carefully check after each change
in the data model.

**** Specific comments

***** Section 5
- File name in <CODE BEGINS> line should be ...@2022-04-08.yang

***** Appendix A.2
- module "ietf-network-topo" doesn't exist, should it be "ietf-network"?

***** Appendix A.3
- leaf "middle-percentile" should probably be "intermediate-percentile".
- leaf "unit-values" should be "unit-value"
- The leaf "ietf-network-vpn-pm:inter-vpn-access-interface"
  is illegal (probably misplaced)