Last Call Review of draft-ietf-pce-pcep-flowspec-09
review-ietf-pce-pcep-flowspec-09-tsvart-lc-touch-2020-07-03-00
Request | Review of | draft-ietf-pce-pcep-flowspec |
---|---|---|
Requested revision | No specific revision (document currently at 13) | |
Type | Last Call Review | |
Team | Transport Area Review Team (tsvart) | |
Deadline | 2020-07-06 | |
Requested | 2020-06-22 | |
Authors | Dhruv Dhody , Adrian Farrel , Zhenbin Li | |
I-D last updated | 2020-07-03 | |
Completed reviews |
Rtgdir Early review of -05
by Acee Lindem
(diff)
Tsvart Last Call review of -09 by Dr. Joseph D. Touch (diff) Secdir Last Call review of -09 by Scott G. Kelly (diff) Genart Last Call review of -09 by Roni Even (diff) |
|
Assignment | Reviewer | Dr. Joseph D. Touch |
State | Completed | |
Request | Last Call review on draft-ietf-pce-pcep-flowspec by Transport Area Review Team Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/tsv-art/sp92tg009Lc683L1LdSUHPh_-gQ | |
Reviewed revision | 09 (document currently at 13) | |
Result | Ready w/nits | |
Completed | 2020-07-03 |
review-ietf-pce-pcep-flowspec-09-tsvart-lc-touch-2020-07-03-00
This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. Overall, the document has no direct transport issues. There are potential issues in coupled documents, notably in draft-ietf-idr-rfc5575bis. Section 4.2.2.4 of that other document indicates three issues of concern: 1) inability to handle transport protocols other than TCP and UDP (e.g., SCTP or DCCP), 2) inability to handle any but initial fragments, and 3) the omission of addressing MTU issues in the associated tunnels. Presumably those will be addressed when that document is reviewed more thoroughly. Nits: I would encourage a revision of the abstract to focus on this document and its contributions, particularly as a single paragraph. The abstract of this document buries the lede; the final sentence would be usefully moved to the front and supporting material explaining context can be moved into the intro or a background section. The abstract could more usefully provide a summary of the actual contents of this document instead, e.g., from paragraph 7 of the introduction. The introduction has similar issues; the document itself is not discussed until the 6th paragraph. Again, it would be useful to focus on this document and address the relation of its contents to other documents and the overall PCE architecture in a background section separately. It also seems odd that this paragraph (#6 of the intro) undermines the terminology of the document that this supplements (as cited in the abstract). These documents as a pair should have consistent use of terminology, coining new terms as needed rather than redefining a key term as different in the two.