Last Call Review of draft-ietf-pce-stateful-path-protection-08
review-ietf-pce-stateful-path-protection-08-genart-lc-resnick-2019-08-28-00

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-pce-stateful-path-protection-08
Reviewer: Pete Resnick
Review Date: 2019-08-28
IETF LC End Date: 2019-08-28
IESG Telechat date: Not scheduled for a telechat

Summary: Ready

No issues of substance that I can see. A few editorial suggestions below, but
nothing earth-shattering.

Major issues: None.

Minor issues: None.

Nits/editorial comments:

Purely editorial suggestions:

Section 3.1:

Delete:
   This document defines a new Association type, the "Path Protection
   Association Type", value will be assigned by IANA (TBD1).

You already say this in the first paragraph.

Section 3.2:

OLD
   The type (16 bits) of the TLV is to be assigned by IANA.  The length
   field (16 bit) has a fixed value of 4.
NEW
   The type (16 bits) of the TLV is TBD2.  The length field (16 bit)
   has a fixed value of 4.

It would probably be caught by the RFC Editor the way you had it, but this way
IANA and the RFC Editor can search and replace for anything with "TBD".

OLD
     |         Type = TBD2         |              Length             |
NEW
     |         Type = TBD2         |          Length = 4             |

OLD
     |   PT      |     Path Protection Association Flags         |S|P|
NEW
     |   PT      |                Unassigned                     |S|P|

Section 6:

At the top of the section, I suggest putting in the following:

[Note to RFC Editor and IANA: Sections 3.1, 3.2, and 4.5 contain "TBD1" through
"TBD5" those should be replaced by the values that IANA assigns. Also, Section
4.5 includes several occurrences of the phrase "(Early allocation by IANA)";
please confirm that the value mentioned there is correct and delete that phrase
from the document before publication.]