Last Call Review of draft-ietf-pce-vendor-constraints-11
review-ietf-pce-vendor-constraints-11-secdir-lc-kumari-2013-12-05-00

Request Review of draft-ietf-pce-vendor-constraints
Requested rev. no specific revision
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2013-12-09
Requested 2013-11-28
Other Reviews Genart Last Call review of -11 by Robert Sparks
Opsdir Last Call review of -11 by Susan Hares
Review State Completed
Reviewer Warren Kumari
Review review-ietf-pce-vendor-constraints-11-secdir-lc-kumari-2013-12-05
Posted at https://www.ietf.org/mail-archive/web/secdir/current/msg04416.html
Reviewed rev. 11
Review result Has Nits
Draft last updated 2013-12-05
Review completed: 2013-12-05

Review
review-ietf-pce-vendor-constraints-11-secdir-lc-kumari-2013-12-05

Be ye not afraid...
I have reviewed this document as part of the security directorate's 
ongoing effort to review all IETF documents being processed by the 
IESG.  These comments were written primarily for the benefit of the 
security area directors.  Document editors and WG chairs should treat 
these comments just like any other last call comments.

Summary: LGTM.

Version reviewed:
Conveying Vendor-Specific Constraints in the Path Computation
Element communication Protocol
draft-ietf-pce-vendor-constraints-11.txt


Notes: I did *not* perform a formal language check. At a quick glance it looks good though.

Nits: I would like to have a table of contents. This may be a personal preference though….

While performing this review I kept thinking "Mwahaha. This can be used to carry
arbitrary information with any PCEP object that supports TLVs....  I can kvetch about the
DoS potential". But, the authors foiled my plan to rant by mentioning this in the 
Security Considerations section and even mentioning a mitigation.
Curses! Foiled again.

W




-- 
Outside of a dog, a book is your best friend, and inside of a dog, it's too dark to read