Last Call Review of draft-ietf-pcp-third-party-id-option-03
review-ietf-pcp-third-party-id-option-03-genart-lc-krishnan-2015-11-02-00

Request Review of draft-ietf-pcp-third-party-id-option
Requested revision No specific revision (document currently at 08)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2015-11-02
Requested 2015-10-22
Authors Andreas Ripke , Rolf Winter , Thomas Dietz , Juergen Quittek , Rafael Lopez da Silva
I-D last updated 2015-11-02
Completed reviews Genart Last Call review of -03 by Suresh Krishnan (diff)
Genart Telechat review of -04 by Suresh Krishnan (diff)
Secdir Last Call review of -03 by Tina Tsou (Ting ZOU) (diff)
Opsdir Last Call review of -03 by Tim Chown (diff)
Assignment Reviewer Suresh Krishnan
State Completed
Request Last Call review on draft-ietf-pcp-third-party-id-option by General Area Review Team (Gen-ART) Assigned
Reviewed revision 03 (document currently at 08)
Result Almost ready
Completed 2015-11-02
review-ietf-pcp-third-party-id-option-03-genart-lc-krishnan-2015-11-02-00
I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<

http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Please wait for direction from your document shepherd or AD before
posting a new version of the draft.

Document: draft-ietf-pcp-third-party-id-option-04.txt
Reviewer: Suresh Krishnan
Review Date: 2015/11/17
IESG Telechat date: 2015/11/19

Summary: The draft is almost ready for publication as a Proposed Standard but 
I do have a major issue that needs to be addressed.

Major
=====

* Section 5.2

The draft is a bit underspecified on how the THIRD_PARTY_ID carried in the 
option is compared to existing entries in the mapping table in the processing 
of request messages. Given that the option itself is loosely specified 
(allowing pretty much anything to be used as the ID) I think it is going to 
be very difficult to realize interoperable implementations unless the 
comparison method is clearly specified. e.g. Consider one of the options for 
THIRD_PARTY_ID described in the document - the MAC address. It could be 
carried as 48 bits binary (aabbccddeeff), hyphen delimited string of hex 
digits ("aa-bb-cc-dd-ee-ff") , colon delimited string of hex digits 
("aa:bb:cc:dd:ee:ff") with upper case and lower case variants. If you intend 
this to be an exact bit by bit comparison, it would be helpful if you state 
it explicitly. If not, please state that as well.

Minor
=====

* IANA considerations

"  [NOTE for IANA: Please allocate a PCP Option Code at
    

http://www.iana.org/assignments/pcp-parameters/pcp-


    parameters.xml#option-rules]"

The URL for this registry is wrong. Did you mean



http://www.iana.org/assignments/pcp-parameters/pcp-parameters.xml#options



instead?

Thanks
Suresh