Last Call Review of draft-ietf-pim-drlb-13
review-ietf-pim-drlb-13-tsvart-lc-scharf-2019-10-29-00

Request Review of draft-ietf-pim-drlb
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team Transport Area Review Team (tsvart)
Deadline 2019-11-07
Requested 2019-10-24
Authors Yiqun Cai, Heidi Ou, Sri Vallepalli, mankamana mishra, Stig Venaas, Andy Green
Draft last updated 2019-10-29
Completed reviews Rtgdir Last Call review of -13 by Ben Niven-Jenkins
Genart Last Call review of -13 by Pete Resnick
Tsvart Last Call review of -13 by Michael Scharf
Opsdir Last Call review of -13 by Joe Clarke
Assignment Reviewer Michael Scharf
State Completed
Review review-ietf-pim-drlb-13-tsvart-lc-scharf-2019-10-29
Posted at https://mailarchive.ietf.org/arch/msg/tsv-art/wjBrTmCXBkasitLRRYh9BFl-MYA
Reviewed rev. 13
Review result Ready
Review completed: 2019-10-29

Review
review-ietf-pim-drlb-13-tsvart-lc-scharf-2019-10-29

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

As far as I can see there are no fundamental transport-related issues in this document. All in all, the impact of selecting a Group Designated Router may be quite similar to the existing PIM-SM selection of a Designated Router.

A little bit of wordsmithing: In Section 6, it could be useful to replace the term "enough total capacity" by another term, such as "enough available capacity" or "enough spare capacity". The router links can obviously also carry other, non-PIM traffic. Then there must be enough available bandwidth left for the PIM traffic on top of non-PIM traffic. The term "total capacity" is a bit vague; it could possibly refer to the physical link capacity (e.g., 1 Gbit/s for Gigabit Ethernet). Only considering the physical link capacity would not be correct. Actually, one could write more about the traffic engineering aspects of GDR selection, e.g., whether it is realistic that traffic distribution is really equal. Yet, given that there seems to be only one implementation according to the shepherd write-up, just changing the term may be sufficient.