Last Call Review of draft-ietf-pim-yang-12
review-ietf-pim-yang-12-secdir-lc-shore-2018-01-01-00

Request Review of draft-ietf-pim-yang
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2017-12-22
Requested 2017-12-08
Other Reviews Yangdoctors Early review of -00 by Dean Bogdanovic (diff)
Yangdoctors Last Call review of -12 by Jürgen Schönwälder (diff)
Rtgdir Telechat review of -12 by Adrian Farrel (diff)
Opsdir Last Call review of -12 by Jürgen Schönwälder (diff)
Genart Last Call review of -12 by Roni Even (diff)
Review State Completed
Reviewer Melinda Shore
Review review-ietf-pim-yang-12-secdir-lc-shore-2018-01-01
Posted at https://mailarchive.ietf.org/arch/msg/secdir/B-mPKNkjtjtBHHRoMa4-PLnM_x0
Reviewed rev. 12 (document currently at 13)
Review result Ready
Draft last updated 2018-01-01
Review completed: 2018-01-01

Review
review-ietf-pim-yang-12-secdir-lc-shore-2018-01-01

This document presents a YANG model for devices that implement protocol independent multicast (PIM).  The bulk of this document contains data model definitions for the base model and for PIM YANG models and is beyond the scope of this review.

The security considerations section appears to be derived directly from published YANG model RFCs and seems reasonable.  The nits checker picked up some outdated references and two downrefs (Normative reference to an Informational RFC: RFC 3569 and Normative reference to an Experimental RFC: RFC 3973) as well as several outdated references, and those will need to be fixed prior to publication.

Overall, the document quality is good.