Last Call Review of draft-ietf-rift-yang-13
review-ietf-rift-yang-13-rtgdir-lc-peng-2024-06-24-00

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-rift-yang-13
Reviewer: Shuping Peng
Review Date: 24 June 2024
IETF LC End Date: --
Intended Status: Standards

Summary:
This document is basically ready for publication but has nits that should be
considered prior to publication.

Comments:

Section 4

1) "Network Configuration Access Control Model (NACM) [RFC8341] provides..."
In RFC8341, NACM stands for NETCONF Access Control Model, being stated as
NETCONF Access Control Model (NACM) throughout the document. So it seems that
the usage in the current draft is not consistent with RFC8341.

2) "unauthorized modification of most RIFT configurations will pose there own
set of security risks" "there" -> "their"?

Major Issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits:

Section 4

s/For example, the configuration changing of configured-level or system-id,
will lead to all the neighbor connections of this node rebuilt. /For example,
the configuration changing of configured-level or system-id will lead to all
the neighbor connections of this node rebuilt.

s/The modification of interface, will lead to the neighbor state changing.
/The modification of interface will lead to the neighbor state changing.