Last Call Review of draft-ietf-rtgwg-yang-rib-extend-17
review-ietf-rtgwg-yang-rib-extend-17-yangdoctors-lc-bjorklund-2023-05-04-00

This is the third YANG doctor review of this document (I have reviewed -17).
All comments from my previous review have been addressed.

So, I have only two very minor comments.

o  The "description" of the YANG module now reads:

     This document defines a YANG data model which extends
     the RIBs defined in ietf-routing YANG module with more
     route attributes.

   In the module itself, we usually write "This YANG module ...".  So perhaps simply

     This YANG module extends the RIBs defined in the 'ietf-routing' YANG module
     with more route attributes.

o  Use single quotes to refer to schema nodes.

   The "description" of the leaf "routes" has:

     "Total routes for protocol in the RIB.";

   This looks odd, the grammar is not correct.  Then I realized that the word "protocol" refers
   to the leaf "protocol".  So I suggest:

      "Total routes for 'protocol' in the RIB.";

   The same comment applies to some other descriptions as well.



/martin