Early Review of draft-ietf-rtgwg-yang-vrrp-02
review-ietf-rtgwg-yang-vrrp-02-rtgdir-early-rogge-2017-04-24-00

Request Review of draft-ietf-rtgwg-yang-vrrp
Requested rev. no specific revision (document currently at 11)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2017-01-12
Requested 2016-12-09
Requested by Jonathan Hardwick
Other Reviews Yangdoctors Early review of -01 by Radek Krejčí (diff)
Genart Last Call review of -07 by Linda Dunbar (diff)
Secdir Last Call review of -07 by Rich Salz (diff)
Opsdir Last Call review of -08 by Zitao Wang (diff)
Genart Telechat review of -08 by Linda Dunbar (diff)
Review State Completed
Reviewer Henning Rogge
Review review-ietf-rtgwg-yang-vrrp-02-rtgdir-early-rogge-2017-04-24
Posted at https://www.ietf.org/mail-archive/web/rtgwg/current/msg06026.html
Reviewed rev. 02 (document currently at 11)
Review result Has Nits
Draft last updated 2017-04-24
Review completed: 2017-04-24

Review
review-ietf-rtgwg-yang-vrrp-02-rtgdir-early-rogge-2017-04-24

Hi,

Jonathan Hardwick asked me to do an early review of the draft-ietf-rtgwg-yang-vrrp document (currently revision 02) for the routing directorate.

The draft itself is pretty straight forward and compact, especially when you consider that a lot of text has to be repeated two or four times (IPv4/IPv6, config vs. read-only state).

But I had quite a bit of trouble mapping the phrases from the new draft-ietf-rtgwg-yang-vrrp-02 document to the existing VRRP documents (e.g. RFC5798). This might come from my unfamilarity with VRRP.

The draft YANG model allows to read (if:interfaces-state) and configure (if:interfaces) virtual IP addresses, but this does not seem to be a common phrase from the RFCs. Is it the same as "address of the virtual router" often mentioned in RFC5798?

In addition to this, I found (I think) a typo or inconsistency in Appendix A:
the ascii art says "eth0" but tree says "eth1".

Henning Rogge