Last Call Review of draft-ietf-rtgwg-yang-vrrp-08
review-ietf-rtgwg-yang-vrrp-08-opsdir-lc-wang-2017-12-19-00

Request Review of draft-ietf-rtgwg-yang-vrrp
Requested rev. no specific revision (document currently at 09)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2017-12-12
Requested 2017-11-28
Other Reviews Rtgdir Early review of -02 by Henning Rogge (diff)
Yangdoctors Early review of -01 by Radek Krejčí (diff)
Genart Last Call review of -07 by Linda Dunbar (diff)
Secdir Last Call review of -07 by Rich Salz (diff)
Genart Telechat review of -08 by Linda Dunbar (diff)
Review State Completed
Reviewer Zitao Wang
Review review-ietf-rtgwg-yang-vrrp-08-opsdir-lc-wang-2017-12-19
Posted at https://www.ietf.org/mail-archive/web/ops-dir/current/msg02970.html
Reviewed rev. 08 (document currently at 09)
Review result Has Nits
Draft last updated 2017-12-19
Review completed: 2017-12-19

Review
review-ietf-rtgwg-yang-vrrp-08-opsdir-lc-wang-2017-12-19

Reviewer: Zitao Wang (Michael)

Review result: Ready with Nits

 

I have reviewed this document as part of the Operational directorate’s ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review.  Document editors and WG chairs should treat these comments just like any other last call comments.

 

Document reviewed:  draft-ietf-rtgwg-yang-vrrp-07
 

Summary:

 

This document describes a data model for Virtual Router Redundancy Protocol(VRRP). Both version 2 and version 3 of VRRP are covered.

 

I have reviewed this document, it make sense and is written very clear.The YANG data model complies with NMDA architecture, and running with no error.

 

But I am concerning about some names of containers and leaves. For examples:

 

#1 the leaf virtual-routers, it seems to present the “number of virtual routers”, but the “virtual-routers” seems not able to help reader to immediate understand that this is a statistic parameter. I suggest changing it to “num-virtual-routers”.

 

#2 the leaf interfaces under the “vrrp-global-state-attributes” grouping, similar to #1;

 

#3 the container “statistics” under “vrrp-global-state-attributes” grouping. This container present the global statistics parameters. I suggest changing the name to “global-statistics”, since the same name also appear in “vrrp-instance” list.

 

#4 the operational state container “vrrp”, suggest modifying it to another name like “vrrp-state”, because it can help reader to quick understand what it means.

 

I know that these nits are not big deal, but I believe a clear nomenclature can help the reader understand what it really mean, especially for the reader who like to review the schema tree first. 

 

And also, a run of idnits revealed there were 8 warnings and 5 comments, please fix them.
 
 

Summary: 0 errors (**), 0 flaws (~~), 8 warnings (==), 5 comments (--).