Skip to main content

Last Call Review of draft-ietf-sidrops-8210bis-06
review-ietf-sidrops-8210bis-06-tsvart-lc-tuexen-2022-04-29-00

Request Review of draft-ietf-sidrops-8210bis
Requested revision No specific revision (document currently at 12)
Type Last Call Review
Team Transport Area Review Team (tsvart)
Deadline 2022-04-29
Requested 2022-04-15
Authors Randy Bush , Rob Austein
I-D last updated 2022-04-29
Completed reviews Tsvart Last Call review of -06 by Michael Tüxen (diff)
Genart Last Call review of -06 by Stewart Bryant (diff)
Rtgdir Telechat review of -06 by Mohamed Boucadair (diff)
Opsdir Last Call review of -06 by Bo Wu (diff)
Opsdir Telechat review of -08 by Bo Wu (diff)
Assignment Reviewer Michael Tüxen
State Completed
Request Last Call review on draft-ietf-sidrops-8210bis by Transport Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/tsv-art/2Wdl82vOrWov1hG2rYkke-_IiZI
Reviewed revision 06 (document currently at 12)
Result Ready w/nits
Completed 2022-04-29
review-ietf-sidrops-8210bis-06-tsvart-lc-tuexen-2022-04-29-00
This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Addressing the following comments might help to improve the document:

1. In the first paragraph of Section 4, the term 'connection' is used.
   I guess this is referring to a 'transport connection'. If that is
   true, using 'transport connection' improves readability.

2. Section 4 talks about connection establishment. When should a
   connection be terminated?

3. Section 4 talks about connection establishment. What happens
   if a connection is terminated in a graceful or non-graceful way?

4. Section 6 provides values for timers. The minimum values for the
   Refresh Interval and the Retry Interval, both 1 second, might
   interfere with loss recovery timers of the underlying transport
   protocol. Is there any mechanism in the protocol to deal with this?

5. Section 9 describes that end points SHOULD use keep-alives, if
   available at the transport layer. Any recommendation regarding the
   time after which it should be sent and about the frequency?

Best regards
Michael