Skip to main content

Last Call Review of draft-ietf-tcpm-hystartplusplus-12
review-ietf-tcpm-hystartplusplus-12-secdir-lc-sethi-2023-01-22-00

Request Review of draft-ietf-tcpm-hystartplusplus
Requested revision No specific revision (document currently at 14)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2023-01-25
Requested 2023-01-11
Authors Praveen Balasubramanian , Yi Huang , Matt Olson
I-D last updated 2023-01-22
Completed reviews Secdir Last Call review of -12 by Mohit Sethi (diff)
Genart Last Call review of -13 by Stewart Bryant (diff)
Assignment Reviewer Mohit Sethi
State Completed
Request Last Call review on draft-ietf-tcpm-hystartplusplus by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/kHbY1E4WTGVt_pU-BN9G9k7uq34
Reviewed revision 12 (document currently at 14)
Result Has nits
Completed 2023-01-22
review-ietf-tcpm-hystartplusplus-12-secdir-lc-sethi-2023-01-22-00
I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG. These comments
were written primarily for the benefit of the security area directors. Document
editors and WG chairs should treat these comments just like any other last-call
comments.

This document defines an algorithm (HyStart++) for the start phase of
congestion control to prevent high packet loss and jitter. While the algorithm
is intended for TCP, it can also be used by QUIC and SCTP.

Nits:
Please expand RTO on first use.

The "Security Considerations" section only contains a pointer to RFC 5681. I
think this is insufficient. I recommend copying the text from RFC 5681 that is
applicable while retaining a reference to RFC 5681. For example, it is not
clear to me if the RECOMMENDATION against ACK division attack stated in RFC
5681 is also applicable for HyStart++.