Telechat Review of draft-ietf-tcpm-rfc793bis-25
review-ietf-tcpm-rfc793bis-25-intdir-telechat-volz-2021-09-22-00
Request | Review of | draft-ietf-tcpm-rfc793bis |
---|---|---|
Requested revision | No specific revision (document currently at 28) | |
Type | Telechat Review | |
Team | Internet Area Directorate (intdir) | |
Deadline | 2021-09-21 | |
Requested | 2021-09-10 | |
Requested by | Éric Vyncke | |
Authors | Wesley Eddy | |
I-D last updated | 2021-09-22 | |
Completed reviews |
Genart Last Call review of -24
by Francis Dupont
(diff)
Opsdir Last Call review of -24 by Sarah Banks (diff) Secdir Last Call review of -24 by Kyle Rose (diff) Secdir Telechat review of -25 by Kyle Rose (diff) Intdir Telechat review of -25 by Bernie Volz (diff) |
|
Comments |
This is rather long document but it is also BCP 7! An Internet foundation :-O I do not expect anything fundamentally wrong but having an Internet area reviewer on this document will be helpful for the IESG evaluation. No need to be a 'transport' oriented reviewer but a new pair of fresh eyes is probably useful. Thank you -éric |
|
Assignment | Reviewer | Bernie Volz |
State | Completed | |
Request | Telechat review on draft-ietf-tcpm-rfc793bis by Internet Area Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/int-dir/8KI-kuBmx_PEHLCjOgMRqkJMpD0 | |
Reviewed revision | 25 (document currently at 28) | |
Result | Ready | |
Completed | 2021-09-22 |
review-ietf-tcpm-rfc793bis-25-intdir-telechat-volz-2021-09-22-00
I am an assigned INT directorate reviewer for draft-ietf-tcpm-rfc793bis (-25). These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/. Based on my review, if I was on the IESG I would ballot this document as YES (or NO OBJECTION). This document is useful to simplify the work of TCP software maintainers and future TCP implementers. Having implemented several TCP stacks (albeit in the late 1980s and 1990s before many of the documents incorporated and/or referenced where written), I see that this updated specification would greatly assist implementers and maintainers. It has impact to the INT area in that proper and current operation of TCP stacks is critical to the operation of the Internet. A few very minor nits (most of these are just things the RFC-Editor will review): - That the Glossary is near the end, rather than the beginning, is a bit unusual. And, some terms are defined inline (such as 3WHS, and not included in the glossary). Likely standardizing this would be a fairly large undertaking. - There is one use of "three way" instead of "three-way". - There is one instance of "receivers's" which I think should just be "reliever's". - "recomendations" is misspelled. - There are mixed uses of "lower level" and "lower-level". - There is "users authority" which I think should be "user's authority". - The TCP Header table in the IANA section might use the "footnote" technique of the table in Appendix B to avoid the page width issues. Thanks to the TCPM WG and authors for putting this document together.