Last Call Review of draft-ietf-trill-o-pw-03
review-ietf-trill-o-pw-03-opsdir-lc-tsou-2013-12-30-00
| Request | Review of | draft-ietf-trill-o-pw |
|---|---|---|
| Requested revision | No specific revision (document currently at 06) | |
| Type | Last Call Review | |
| Team | Ops Directorate (opsdir) | |
| Deadline | 2014-01-07 | |
| Requested | 2013-12-11 | |
| Authors | Lucy Yong , Donald E. Eastlake 3rd , Sam Aldrin , Jon Hudson | |
| I-D last updated | 2013-12-30 | |
| Completed reviews |
Genart Last Call review of -03
by Christer Holmberg
(diff)
Genart Telechat review of -04 by Christer Holmberg (diff) Secdir Last Call review of -03 by Yaron Sheffer (diff) Opsdir Last Call review of -03 by Tina Tsou (Ting ZOU) (diff) |
|
| Assignment | Reviewer | Tina Tsou (Ting ZOU) |
| State | Completed | |
| Request | Last Call review on draft-ietf-trill-o-pw by Ops Directorate Assigned | |
| Reviewed revision | 03 (document currently at 06) | |
| Result | Has issues | |
| Completed | 2013-12-30 |
review-ietf-trill-o-pw-03-opsdir-lc-tsou-2013-12-30-00
Dear all, Season’s greetings! I have reviewed this document as part of the operations directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the operations area directors. Document editors and WG chairs should treat these comments just like any other last call comments. Basically it is an informational guidance on how to connect trill RBridges using PW without changing TRILL and PW specifications. You may want to take the following reviews into consideration. 1. Section 2.1: The sending pseudowire TRILL Switch port MUST copy the priority of the TRILL Data packets being sent to the 3-bit Traffic Class field of the pseudowire label… I think priority here refers to priority code in outer.VLAN. Better clarify it. 2. Page 4 right above section 2.1, it says, “This application needs no additions to the existing pseudowire standards”. PPP PW in section 2.2 does not require any change to current RFCs for TRILL or PW. However the appendix says it may not be true for the other types of PW. So I suggest to give a brief explanation. For PW type other than 0x0007, it may require some changes otherwise may not be directly applicable, e.g. for type 0x0004. Then the readers may refer to the appendix. Nit: last paragraph in Section 2, sentence fragment: OLD A pseudowire is carried over a packet switched network tunnel [RFC3985]. For example, an MPLS or MPLS-TP label switched path tunnel in MPLS networks. NEW A pseudowire is carried over a packet switched network tunnel [RFC3985], for example, an MPLS or MPLS-TP label switched path tunnel in MPLS networks. Nit: second last paragraph of Sec. 2.1, unnecessary use of abbreviation (which otherwise would have to be spelled out on first use anyway): OLD ... constraint on the TRILL campus wide Sz ... NEW ... constraint on the TRILL campus wide MTU size ... OLD ... MUST be used in helping to determine Sz ... NEW ... MUST be used in helping to determine MTU size ... Thank you, Tina