Last Call Review of draft-ietf-xmpp-websocket-07
review-ietf-xmpp-websocket-07-opsdir-lc-schoenwaelder-2014-06-27-00
Request | Review of | draft-ietf-xmpp-websocket |
---|---|---|
Requested revision | No specific revision (document currently at 10) | |
Type | Last Call Review | |
Team | Ops Directorate (opsdir) | |
Deadline | 2014-07-04 | |
Requested | 2014-06-24 | |
Authors | Lance Stout, Jack Moffitt , Eric Cestari | |
I-D last updated | 2014-06-27 | |
Completed reviews |
Genart Last Call review of -07
by Dan Romascanu
(diff)
Genart Last Call review of -07 by Dan Romascanu (diff) Secdir Last Call review of -07 by Magnus Nyström (diff) Opsdir Last Call review of -07 by Jürgen Schönwälder (diff) |
|
Assignment | Reviewer | Jürgen Schönwälder |
State | Completed | |
Request | Last Call review on draft-ietf-xmpp-websocket by Ops Directorate Assigned | |
Reviewed revision | 07 (document currently at 10) | |
Result | Has nits | |
Completed | 2014-06-27 |
review-ietf-xmpp-websocket-07-opsdir-lc-schoenwaelder-2014-06-27-00
Hi, I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the operational area directors. Document editors and WG chairs should treat these comments just like any other last call comments. This document defines how to run XMPP over WebSockets. The intended status is standards track. I believe the document is in a good shape and basically ready to go. In particular, I do not see that the XMPP over WebSockets specification creates any operational issues. Some editorial nits: - Sec 1: The term 'raw socket' can be potentially mis-understood, perhaps simply remove 'over row sockets' completely (I think the message of the sentence remains intact without these words). - Sec 3.1: The text says that both client and server MUST have |xmpp| in the list of protocols for the |Sec-WebSocket-Protocol| header. The text does not detail what happens if this is not the case. Is there be a defined behavior if this protocol negotiation fails? - Sec 3.6.1: There is a closing parenthesis missing at the end of the first paragraph. - Sec 3.9: Word missing in "it MUST be enabled the WebSocket layer", perhaps you meant "it MUST be enabled _by_ the WebSocket layer"? /js -- Juergen Schoenwaelder Jacobs University Bremen gGmbH Phone: +49 421 200 3587 Campus Ring 1, 28759 Bremen, Germany Fax: +49 421 200 3103 < http://www.jacobs-university.de/ >