Last Call Review of draft-ietf-xrblock-rtcp-xr-burst-gap-loss-08
review-ietf-xrblock-rtcp-xr-burst-gap-loss-08-secdir-lc-lonvick-2013-03-21-00
| Request | Review of | draft-ietf-xrblock-rtcp-xr-burst-gap-loss |
|---|---|---|
| Requested revision | No specific revision (document currently at 12) | |
| Type | Last Call Review | |
| Team | Security Area Directorate (secdir) | |
| Deadline | 2013-03-15 | |
| Requested | 2013-03-07 | |
| Authors | Alan Clark , Sunshine Zhang , Jing Zhao , Qin Wu | |
| Draft last updated | 2013-03-21 | |
| Completed reviews |
Secdir Last Call review of -08
by
Chris M. Lonvick
(diff)
|
|
| Assignment | Reviewer | Chris M. Lonvick |
| State | Completed | |
| Review |
review-ietf-xrblock-rtcp-xr-burst-gap-loss-08-secdir-lc-lonvick-2013-03-21
|
|
| Reviewed revision | 08 (document currently at 12) | |
| Result | Has Nits | |
| Completed | 2013-03-21 |
review-ietf-xrblock-rtcp-xr-burst-gap-loss-08-secdir-lc-lonvick-2013-03-21-00
Hi,
I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG. These comments were written primarily for the benefit of the
security area directors. Document editors and WG chairs should treat
these comments just like any other last call comments.
I don't see any problems with this. The only nit that I found was that I
couldn't fully understand a part of section 3.2.
Loss and Discard Combination flag (C): 1 bit
The 'C' flag is used to indicate whether combining loss/discard
report is needed. This field MUST be set to '1' if the burst gap
loss report is present in conjunction with the burst gap discard
report in the same compound RTCP packet and MUST be set to '0'
otherwise. If the burst gap discard is not sent with the burst
gap loss, then the receiver MUST discard the burst gap loss with
'C' flag set to 1. If the 'C' flag is set to 0, then receiver
MUST NOT discard the burst gap loss Metrics Block when the burst
gap discard is not received.
Maybe something like the following:
The 'C' flag is used to indicate whether the loss/discard report is
combined with the burst gap loss report in the same compound RTCP packet.
The value MUST be set to '1' if the loss/discard report and the burst gap
loss report are combined. Otherwise, the value MUST be set to '0'. If
the burst gap discard is not sent with the burst gap loss, then the
receiver MUST discard the burst gap loss with 'C' flag set to 1. If the
'C' flag is set to 0, then receiver MUST NOT discard the burst gap loss
Metrics Block when the burst gap discard is not received.
Best regards,
Chris