Last Call Review of draft-schaad-pkix-rfc2875-bis-03
review-schaad-pkix-rfc2875-bis-03-genart-lc-thomson-2012-12-07-00

Request Review of draft-schaad-pkix-rfc2875-bis
Requested rev. no specific revision (document currently at 08)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2013-01-02
Requested 2012-12-06
Authors Jim Schaad, Hemma Prafullchandra
Draft last updated 2012-12-07
Completed reviews Genart Last Call review of -03 by Martin Thomson (diff)
Assignment Reviewer Martin Thomson 
State Completed
Review review-schaad-pkix-rfc2875-bis-03-genart-lc-thomson-2012-12-07
Reviewed rev. 03 (document currently at 08)
Review result Ready
Review completed: 2012-12-07

Review
review-schaad-pkix-rfc2875-bis-03-genart-lc-thomson-2012-12-07

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at

<

http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: raft-schaad-pkix-rfc2875-bis-03
Reviewer: Martin Thomson
Review Date: 2012-12-06
IETF LC End Date: Aaaages
IESG Telechat date: (if known)

Summary: Looks good to me.  Ship it.

Nits/editorial comments:

Section 3 does not establish a notation convention for multiplication.
 I didn't find a specific place that this was a problem, but it seemed
appropriate since multiplications was, in some places denoted 'n*b'
and others as 'xy', even though multi-character identifiers are used
in many places.  This does imply that a precedence override is
necessary.  I suggest parentheses, since they are already used
extensively.

Section 3: s/MAC funtion/MAC functions/

Section 5: could use a more rigorous list construction, the
definitions all run together

Needs more ASN.1

--Martin