Advertising a Router's Local Addresses in OSPF Traffic Engineering (TE) Extensions
RFC 5786
Yes
(Ross Callon)
No Objection
(Cullen Jennings)
(Jari Arkko)
(Lisa Dusseault)
(Magnus Westerlund)
(Pasi Eronen)
(Ralph Droms)
(Robert Sparks)
(Ron Bonica)
(Russ Housley)
(Tim Polk)
Note: This ballot was opened for revision 07 and is now closed.
Lars Eggert
No Objection
Comment
(2009-12-02)
Section 3., paragraph 0: > 3. Rejected Potential Solution This section would make a good appendix. Section 4.1., paragraph 6: > The Node IPv4 Local Address sub-TLV length is in octets. It is the > sum of all n IPv4 Address encodings in the sub-TLV where n is the > number of local addresses included in the sub-TLV. You mean: sum of the *lengths* of all n IPv4 encodings (each of which is 5 octets.) Section 4.1., paragraph 10: > This encoding consumes (PrefixLength + > 31) / 32) 32-bit words. The length calculation needs to be rounded up to be accurate. Section 4.1., paragraph 11: > The Node IPv6 Local Address sub-TLV length is in octets. It is the > sum of all n IPv6 Address encodings in the sub-TLV where n is the > number of local addresses included in the sub-TLV. "sum of *lengths*" (see above)
Adrian Farrel Former IESG member
Yes
Yes
(2009-11-27)
Voting "Yes" but please consider fixing these nits... Section 2.1 For the above reasons this document proposes an enhancement to OSPF TE extensions to advertise the local addresses of a node. s/proposes/defines/ --- Section 4.1 The Node IPv4 Local Address sub-TLV length is in octets. It is the sum of all n IPv4 Address encodings in the sub-TLV where n is the number of local addresses included in the sub-TLV. The use of "sum" is confusing. Perhaps "sum of the lengths"? --- Section 4.1 The Node IPv6 Local Address sub-TLV length is in octets. It is the sum of all n IPv6 Address encodings in the sub-TLV where n is the number of local addresses included in the sub-TLV. Ditto --- Section 4.2 The node attribute TLV must appear in exactly one TE LSA originated by a router. Furthermore, only one node attribute TLV must be advertised in such a LSA. A node attribute TLV must carry at most one Node IPv4 Local Address sub-TLV and at most one Node IPv6 Local Address sub-TLV. I thought that the node attribute TLV was optional, so this looks off. I also wonder if this can be reworded in 2119 langauge. The node attribute TLV MUST NOT appear in more than one TE LSA originated by a router. Furthermore, such an LSA MUST NOT include more than one node attribute TLV. A node attribute TLV MUST NOT carry more than one of each of the Node IPv4 Local Address sub-TLV and the Node IPv6 Local Address sub-TLV. ---
Ross Callon Former IESG member
Yes
Yes
()
Alexey Melnikov Former IESG member
No Objection
No Objection
(2009-11-27)
On page 6: PrefixOptions is an 8-bit field describing various capabilities associated with the prefix [RFC5340]. I think a pointer to Appendix A.4.1.1 in RFC 5340 would be helpful here. 4.2. Operation The node attribute TLV must appear in exactly one TE LSA originated by a router. Furthermore, only one node attribute TLV must be advertised in such a LSA. A node attribute TLV must carry at most one Node IPv4 Local Address sub-TLV and at most one Node IPv6 Local Address sub-TLV. It looks like this section should be using "MUST"s instead of "must"s.
Cullen Jennings Former IESG member
No Objection
No Objection
()
Dan Romascanu Former IESG member
No Objection
No Objection
(2009-12-02)
In the IANA considerations section: > IANA is requested to maintain the registry for the sub-TLVs of the node attribute TLV and reserve value 1 for Node IPv4 Local Address sub-TLV and value 2 for Node IPv6 Local Address sub-TLV. '... to create and maintain the resgistry ...' seems more appropriate.
Jari Arkko Former IESG member
No Objection
No Objection
()
Lisa Dusseault Former IESG member
No Objection
No Objection
()
Magnus Westerlund Former IESG member
No Objection
No Objection
()
Pasi Eronen Former IESG member
No Objection
No Objection
()
Ralph Droms Former IESG member
No Objection
No Objection
()
Robert Sparks Former IESG member
No Objection
No Objection
()
Ron Bonica Former IESG member
No Objection
No Objection
()
Russ Housley Former IESG member
No Objection
No Objection
()
Tim Polk Former IESG member
No Objection
No Objection
()