New ASN.1 Modules for the Evidence Record Syntax (ERS)
RFC 9169

Yes

Roman Danyliw

No Objection

Erik Kline
Francesca Palombini
Lars Eggert
Martin Duke
Murray Kucherawy
Robert Wilton
Warren Kumari
Zaheduzzaman Sarker
Éric Vyncke
(Alvaro Retana)
(Benjamin Kaduk)

Note: This ballot was opened for revision 02 and is now closed.

Roman Danyliw
(was Discuss, Yes) Yes
Erik Kline
No Objection
Francesca Palombini
No Objection
Lars Eggert
No Objection
Comment (2021-08-23 for -02) Sent 
Section 4. , paragraph 6, comment:
An RFC Editor note instructing them to replace [ThisRFC] might be
helpful.
Martin Duke
No Objection
Murray Kucherawy
No Objection
Comment (2021-08-21 for -02) Sent 
The shepherd writeup seems to be missing.

Is the URL for the ITU reference correct?  I tried it in two different browsers and just get a blank page each time.

Other than that, just some nits:

* Everywhere you say "alternate", I think you mean "alternative".

* In the Abstract, in "... the conventions for including these evidence record in the ...", s/record/records/

* In Section one, in "... which continued to be ...", s/continued/continues/
Robert Wilton
No Objection
Warren Kumari
No Objection
Comment (2021-08-24 for -02) Not sent 
The ITU linked worked for me, but a better one might be https://www.itu.int/rec/T-REC-X.208-198811-W/en

Note: This is just a suggestion/thought. No need to reply either way.
Zaheduzzaman Sarker
No Objection
Éric Vyncke
No Objection
Alvaro Retana Former IESG member
No Objection
No Objection (for -02) Not sent 

                            

                        
                    

                
            
                
                    

                        

                            Benjamin Kaduk Former IESG member
                        

                        

                            
                            No Objection
                            
                        

                    

                    

                        

                            

                                No Objection 
                                
                                    (2021-08-25 for -02)
                                
                                
                                    
                                         Sent
                                    
                                
                            

                        

                        
                            

                                
Section 1

   The Evidence Record Syntax (ERS) [RFC4998] provides two ASN.1
   modules, one using the 1988 syntax [OLD-ASN1], which has been
   deprecated by the ITU-T, and another one using the 2002 syntax
   [NEW-ASN1], which continued to be maintained and enhanced.  [...]

This looks a little weird, since RFC 4998 itself claims to provide
modules with the "1988 syntax" and the "1997 syntax", and 1997 is not
equal to 2002.  Maybe we could have another phrase to relate the two?

Section 2

I don't expect that I have access to the definition of Attribute from
2.5.1.1.4 to be able to compare it to the "AttributeSet {{ERSAttrSet}}"
that we define here.

      CryptoInfos ::= SEQUENCE SIZE (1..MAX) OF Attribute
      [...]
      Attributes ::= SET SIZE (1..MAX) OF Attribute

The module from RFC 4998 seems to impose the additional constraint (for
both of these) that the post-extension-marker component
valuesWithContext is absent (but I could be misreading it); is that
particularly noteworthy?

NITS

Abstract

   The Evidence Record Syntax (ERS) and the conventions for including
   these evidence record in the Server-based Certificate Validation

singular/plural mismatch "record"/"these"