Ballot for draft-ietf-rtgwg-vrrp-rfc8347bis
Yes
No Objection
Note: This ballot was opened for revision 16 and is now closed.
Hi Acee, Xufeng, Athanasios, Ravi, and Mingui, Thank you for the effort put into this document. The justification provided in Section 6.1 is strong enough to proceed with the NBC changes without intermediate deprecation steps per 9907. I already reviewed this document in the past upon the request the authors [1], so I only have very minor comments: # No obsolete of VRRP Version 3 OLD: This document obsoletes VRRP Version 3 [RFC8347]. NEW : This document obsoletes [RFC8347]. # Inclusive language changes in RFC 9568 OLD: The following changes have been made consistent with IETF inclusive language guidelines: NEW: The following changes have been made consistent with IETF inclusive language guidelines and changes made in [RFC9568]: # grouping name OLD: * The leaf "effective-priority" was added to the grouping "grouping vrrp-state-attributes" to reflect the effective priority due to NEW: * The leaf "effective-priority" was added to the "vrrp-state-attributes" grouping to reflect the effective priority due to # Fix tree CURRENT: +--ro last-event? identityref +--ro new-active-reason? new-active-reason-type +--ro statistics # 6527 not cited anymore CURRENT: This module references [RFC3768], [RFC9568], and [RFC6527]. … [RFC6527] Tata, K., "Definitions of Managed Objects for Virtual Router Redundancy Protocol Version 3 (VRRPv3)", RFC 6527, DOI 10.17487/RFC6527, March 2012, https://www.rfc-editor.org/info/rfc6527. You may remove that entry. # Long line OLD: when "derived-from-or-self(current()/../version, 'vrrp:vrrp-v3')" { NEW: when "derived-from-or-self(current()/../version, " + " 'vrrp:vrrp-v3')" { # Better to use a reference statement + add section OLD: description "Calculated based on the priority and advertisement interval configuration command parameters. Note that the units are microseconds rather than centiseconds units as configured for advertisement-interval. See RFC 9568."; NEW: description "Calculated based on the priority and advertisement interval configuration command parameters. Note that the units are microseconds rather than centiseconds units as configured for advertisement-interval.”; reference "RFC 9568: Virtual Router Redundancy Protocol (VRRP) Version 3 for IPv4 and IPv6, Section 6.1"; # Explain the type change as well CURRENT: leaf active-transitions { type yang:counter64; description "The total number of times that this virtual router's state has transitioned to 'Active'. The identifier of this leaf is changed to reflect the updated terminology used in RFC 9568."; } May also explain the change to counter64, instead of counter32 as in the previous version. # As this this is a revision, we need to follow 3.8.3.2 of RFC9907 OLD IANA is requested to update the following YANG module in the "YANG Module Names" registry [RFC6020] within the "YANG Parameters" registry group to reference this document: NEW: IANA is requested to register the following YANG module in the "YANG Module Names" registry [RFC6020] [RFC9890] within the "YANG Parameters" registry group. # Ops Considerations You may also add a mention about the few type changes in addition to the inclusive language changes. # RFC8347 is cited as normative, while that will be obsoleted by this doc. Please move that one to be listed as informative. # RFC 6020 is normative: please fix it. Cheers, Med [1] https://mailarchive.ietf.org/arch/msg/rtgwg/ju8w-9Q7ifgc2Jcby1nUSQZWb-M/
Thanks to Dan H. for the SECDIR review. Thanks for the draft and the work goes into it and the adaptation to inclusive language as part of the update. Please read and consider the language update from SECDIR review - it makes the security considerations stronger.
Thanks to Dan Harkins for their secdir review.
Thanks for the work done in this document. Nevertheless, please find below some non-blocking COMMENTS. ### Abstract s/This document describes/This document *specifies*/ as it is a PS. ### Section 1 s/This document introduces/This document *defines*/ ### Section 4 s/A packet has been received with IP TTL (Time-To-Live)/A packet has been received with IP TTL (Time-To-Live) or Hop-Limit/ `leaf ip-ttl-errors` has the correct wording. ### Appendix A Thanks for the IPv6 example :-)
(1) Section 2.4 / Section 3 tree diagrams vs. YANG module:
active-transitions counter type inconsistency
Section 2.4, Figure 3 (IPv4 augment):
373 > +--ro active-transitions? yang:counter32
Section 2.4, Figure 3 (IPv6 augment):
416 > +--ro active-transitions? yang:counter32
Section 3, Figure 5 (IPv4 augment):
553 > +--ro active-transitions? yang:counter32
Section 3, Figure 5 (IPv6 augment):
601 > +--ro active-transitions? yang:counter32
The YANG module itself defines the type as yang:counter64:
1445 > leaf active-transitions {
1446 > type yang:counter64;
Section 6.1 states explicitly:
1779 > Additionally, the type of the "active-transitions" counter has been
1780 > updated from 32 bits to 64 bits consistent with other VRRP counters.
All four tree diagram occurrences still show yang:counter32, which
contradicts both the YANG module and the prose in Section 6.1. The tree
diagrams need to be regenerated to reflect this update.
(2) Section 4, vrrp-state-attributes grouping, skew-time units:
1400 > leaf skew-time {
1401 > type uint32;
1402 > units "microseconds";
1403 > config false;
1404 > description
1405 > "Calculated based on the priority and advertisement
1406 > interval configuration command parameters. Note that
1407 > the units are microseconds rather than centiseconds units
1408 > as configured for advertisement-interval.";
1409 > reference
1410 > "RFC 9568: Virtual Router Redundancy Protocol (VRRP)
1411 > Version 3 for IPv4 and IPv6, Section 6.1";
RFC 9568 Section 6.1 defines Skew_Time as:
> "Time to skew Active_Down_Interval in centiseconds. Calculated as:
> (((256 - Priority) * Active_Adver_Interval) / 256)"
Both Skew_Time and Active_Down_Interval are defined in centiseconds in
RFC 9568. The companion leaf active-down-interval correctly declares
units "centiseconds" (line 1391), but skew-time declares units
"microseconds." The description acknowledges the difference but does
not provide a protocol-level justification for deviating from the
normative reference. This discrepancy was noted by both the OPSDIR
(Dunbar, -18) and GEN-ART (Robles, -15) reviewers and does not appear
to have been resolved in -20. The authors should either:
(a) change the units to centiseconds to match RFC 9568, or
(b) provide a clear explanation of why microseconds are used and how
they relate to the RFC 9568 computation.
----------------------------------------------------------------------
NIT
----------------------------------------------------------------------
All comments below are about very minor potential issues that you may
choose to address in some way - or ignore - as you see fit. Some were
flagged by automated tools (via
https://github.com/larseggert/ietf-reviewtool), so there will likely
be some false positives. There is no need to let me know what you did
with these suggestions.
(These two nits were also noted by the OPSDIR reviewer, Linda Dunbar, thanks Linda,
in her review of -18.)
Section 4, vrrp-state-attributes grouping, effective-priority description:
1373 > The priority 255 is reserved the virtual router owning
1374 > the address.";
s/reserved the/reserved for the/
----------------------------------------------------------------------
Section 1.1, Changes from RFC 8347, last bullet:
128 > * The descriptive text for identify "vrrp-event-owner-preempt" was
129 > updated.
s/for identify/for identity/
Thank you to Linda Dunbar for the GENART review.