Skip to main content

Last Call Review of draft-ietf-ccamp-l1csm-yang-19
review-ietf-ccamp-l1csm-yang-19-rtgdir-lc-leymann-2022-12-12-00

Request Review of draft-ietf-ccamp-l1csm-yang
Requested revision No specific revision (document currently at 26)
Type Last Call Review
Team Routing Area Directorate (rtgdir)
Deadline 2022-11-17
Requested 2022-11-03
Requested by Daniele Ceccarelli
Authors Young Lee , Kwang-koog Lee , Haomian Zheng , Oscar Gonzalez de Dios , Daniele Ceccarelli
I-D last updated 2022-12-12
Completed reviews Intdir Telechat review of -25 by Antoine Fressancourt (diff)
Genart Last Call review of -24 by Dan Romascanu (diff)
Secdir Last Call review of -24 by Yaron Sheffer (diff)
Yangdoctors Early review of -07 by Robert Wilton (diff)
Yangdoctors Last Call review of -15 by Joe Clarke (diff)
Rtgdir Last Call review of -19 by Adrian Farrel (diff)
Rtgdir Last Call review of -19 by Nicolai Leymann (diff)
Comments
Second review requested as agreed with Luc André
Assignment Reviewer Nicolai Leymann
State Completed
Request Last Call review on draft-ietf-ccamp-l1csm-yang by Routing Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/Dh6I7WJf7en-X6sIgUVqTBPPd4E
Reviewed revision 19 (document currently at 26)
Result Ready
Completed 2022-12-12
review-ietf-ccamp-l1csm-yang-19-rtgdir-lc-leymann-2022-12-12-00
Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and
sometimes on special request. The purpose of the review is to provide
assistance to the Routing ADs. For more information about the Routing
Directorate, please see https://trac.ietf.org/trac/rtg/wiki/RtgDir
This is the second review from Routing Directorate.

Overall I think the draft is ready for publication but there a still
a few nits.

This review takes place in support of CCAMP working group last call.

Document: draft-ietf-ccamp-l1csm-yang-19
Reviewer: Nicolai Leymann
Review Date: 09 December 2022
IETF LC End Date: Not yet started
Intended Status: Draft Standard

Nits:
either "Layer 1" or "layer 1" should be used consistently throughout the
document: - Page 5, First sentence:
  "The benefit is that the same layer 1 transport network resources are"
- Page 6,
  "The L1CSM YANG data model describes the layer 1 connectivity services"
References to "RFCXXX", "RFC XXX" and "RFCYYY" need to be fixed.
- (In some cases there is a comment that this needs to be updated but not not
in all cases. E.g., Page 9)

Page 6, Table has no caption, References need to be fixed ("RFCXXX"/"[RFCYYY]")

Some of the comments from Adrians review (e.g., use of "P" as Protcol but also
in different context in Figues are not addressed (yet)).