Skip to main content

Telechat Review of draft-ietf-babel-rtt-extension-05
review-ietf-babel-rtt-extension-05-intdir-telechat-fressancourt-2024-02-12-00

Request Review of draft-ietf-babel-rtt-extension
Requested revision No specific revision (document currently at 07)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2024-02-13
Requested 2024-02-05
Requested by Éric Vyncke
Authors Baptiste Jonglez, Juliusz Chroboczek
I-D last updated 2024-02-12
Completed reviews Secdir Telechat review of -05 by Shivan Kaul Sahib (diff)
Iotdir Telechat review of -05 by Pascal Thubert (diff)
Intdir Telechat review of -05 by Antoine Fressancourt (diff)
Secdir Last Call review of -04 by Shivan Kaul Sahib (diff)
Genart Last Call review of -04 by Roni Even (diff)
Opsdir Last Call review of -04 by Sheng Jiang (diff)
Rtgdir Early review of -03 by Joel M. Halpern (diff)
Assignment Reviewer Antoine Fressancourt
State Completed
Request Telechat review on draft-ietf-babel-rtt-extension by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/xAsfuYy_5LXm7s_IgLzvd5EWRss
Reviewed revision 05 (document currently at 07)
Result Ready w/nits
Completed 2024-02-12
review-ietf-babel-rtt-extension-05-intdir-telechat-fressancourt-2024-02-12-00
I am an assigned INT directorate reviewer for draft-ietf-babel-rtt-extension in
version 05. These comments were written primarily for the benefit of the
Internet Area Directors. Document editors and shepherd(s) should treat these
comments just like they would treat comments from any other IETF contributors
and resolve them along with any other Last Call comments that have been
received. For more details on the INT Directorate, see
https://datatracker.ietf.org/group/intdir/about/
<https://datatracker.ietf.org/group/intdir/about/>.

Based on my review, if I was on the IESG I would ballot this document as YES.

The text of the draft is clearly written, and easy to follow. To the best of my
understanding, the metric, sub-TLVs and mechanisms described in the draft are
consistent with RFC 8966, in particular with the considerations for protocol
extensions in Appendix D.

The following are minor issues (typos, misspelling, minor text improvements)
with the document:

* In some parts of the draft, the authors personalize their text using "we" or
"our" (for instance in section 3.3 or in the introduction of section 4). The
authors might want to rephrase those sentences using a more neutral form.

* In section 4.1, I was frustrated by the use of vague terms like "fairly" or
"somewhat" which gives the impression that the phenomenon described is
difficult to observe, and may not require the use of a proper smoothing
algorithm.

* In section 4.1 and 4.3, the text mentions external references to describe
algorithms that the implementer could be using to avoid strong oscillations in
the route selection algorithm. I would have appreciated to have a rough
intuition of the behavior of those algorithms in the text directly, while
keeping the reference to point to more detailed descriptions.