Last Call Review of draft-ietf-cose-cwt-claims-in-headers-06
review-ietf-cose-cwt-claims-in-headers-06-artart-lc-allocchio-2023-10-19-00
Request | Review of | draft-ietf-cose-cwt-claims-in-headers |
---|---|---|
Requested revision | No specific revision (document currently at 10) | |
Type | Last Call Review | |
Team | ART Area Review Team (artart) | |
Deadline | 2023-10-20 | |
Requested | 2023-10-06 | |
Authors | Tobias Looker , Michael B. Jones | |
I-D last updated | 2023-10-19 | |
Completed reviews |
Artart Last Call review of -06
by Claudio Allocchio
(diff)
Opsdir Last Call review of -07 by Gyan Mishra (diff) Genart Last Call review of -06 by Ines Robles (diff) Secdir Last Call review of -06 by Peter E. Yee (diff) Iotdir Telechat review of -07 by Hannes Tschofenig (diff) |
|
Assignment | Reviewer | Claudio Allocchio |
State | Completed | |
Request | Last Call review on draft-ietf-cose-cwt-claims-in-headers by ART Area Review Team Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/art/kuLLKsPo04s22kyXIIV7AsKkgZM | |
Reviewed revision | 06 (document currently at 10) | |
Result | Ready w/nits | |
Completed | 2023-10-19 |
review-ietf-cose-cwt-claims-in-headers-06-artart-lc-allocchio-2023-10-19-00
The document is basically well written and clear. The only nits I suggest to fix is in the security chapter: it seems a copy/paste of the same sections as RFC 7519 one, but maybe some "expanded statements" on the implication of external signature use and in case about potential risks associated may help the non security expert implementer to better understand the whole picture. Given the above, the document is ready to go.