IETF Last Call Review of draft-ietf-tcpm-prr-rfc6937bis-14
review-ietf-tcpm-prr-rfc6937bis-14-genart-lc-housley-2025-05-27-00
| Request | Review of | draft-ietf-tcpm-prr-rfc6937bis |
|---|---|---|
| Requested revision | No specific revision (document currently at 21) | |
| Type | IETF Last Call Review | |
| Team | General Area Review Team (Gen-ART) (genart) | |
| Deadline | 2025-06-06 | |
| Requested | 2025-05-23 | |
| Authors | Matt Mathis , Neal Cardwell , Yuchung Cheng , Nandita Dukkipati | |
| I-D last updated | 2025-12-19 (Latest revision 2025-06-22) | |
| Completed reviews |
Opsdir IETF Last Call review of -16
by Daniele Ceccarelli
(diff)
Genart IETF Last Call review of -14 by Russ Housley (diff) Perfmetrdir IETF Last Call review of -19 by Paul Aitken (diff) Secdir IETF Last Call review of -16 by Derrell Piper (diff) |
|
| Assignment | Reviewer | Russ Housley |
| State | Completed | |
| Request | IETF Last Call review on draft-ietf-tcpm-prr-rfc6937bis by General Area Review Team (Gen-ART) Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/gen-art/E9C40kGul0iJsaiqfqzf-O9KU1I | |
| Reviewed revision | 14 (document currently at 21) | |
| Result | Almost ready | |
| Completed | 2025-05-27 |
review-ietf-tcpm-prr-rfc6937bis-14-genart-lc-housley-2025-05-27-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-tcpm-prr-rfc6937bis-14 Reviewer: Russ Housley Review Date: 2025-05-27 IETF LC End Date: 2025-06-06 IESG Telechat date: Not scheduled for a telechat Summary: Almost Ready Major Concerns: None Minor Concerns: The Abstract and Section 1 say that this document "updates" the experimental PRR algorithm. This wording is confusing because this document obsoletes RFC 6937. The Abstract and Section 1 should state that this document obsoletes RFC 6937. Avoiding the use of "updates" is desirable. The 7th paragraph of Section 5 begins with "A final change"; yet the 8th paragraph talks about another adaptation to PRR. The last paragraph of Section 5 is not really about changes since the publication of RFC 6937. I'm not sure where this information belongs. Nits: Section 5: s/(i.e. sndcnt is 0)/(i.e., sndcnt is 0)/ Section 5: s/RTO/retransmission timeout (RTO)/ Section 5: s/sets cwnd = ssthresh/sets cwnd to ssthresh/ Section 5: s/ECN/Explicit Congestion Notification (ECN)/ Section 5: s/AQMs/ approaches to Active Queue Management (AQM)/ Section 9: Figure 1 is too wide. Can segment 22 be omitted? If so, the text that follows would say: "ACK#22 (not shown) carries ...". Section 12: s/Janey C. Hoe/Janey C. Hoe/